Automatic port of Microsoft.Extensions.Localization docs #4930

carlossanlop · 2020-10-01T01:35:41Z

Area owners of Microsoft.Extensions.Localization: @maryamariyan @ericstj
Note: The area owners document does not have the label area-Extensions-Localization.

opbld34 · 2020-10-01T01:55:41Z

Docs Build status updates of commit 6839497:

⚠️ Validation status: warnings

File	Status	Preview URL	Details
xml/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.xml	⚠️Warning	View	Details
xml/Microsoft.Extensions.DependencyInjection/PollyServiceCollectionExtensions.xml	⚠️Warning	View	Details
xml/Microsoft.Extensions.Localization/ResourceNamesCache.xml	✅Succeeded	View
xml/Microsoft.Extensions.Localization/StringLocalizer`1.xml	✅Succeeded	View

xml/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.xml

Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.ResourceManagerStringLocalizer._resourceManager'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.Internal.AssemblyWrapper'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.Internal.IResourceStringProvider'.

xml/Microsoft.Extensions.DependencyInjection/PollyServiceCollectionExtensions.xml

Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.PolicyRegistry'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IReadOnlyPolicyRegistry`1'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IReadOnlyPolicyRegistry`1'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.PolicyRegistry'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Try searching in the Docs contributor and Admin Guide
See the frequently asked questions
Post your question in the Docs support channel

ericstj · 2020-10-01T17:06:31Z

@pranavkm @ryanbrandenburg can you have a look, I believe this is https://github.com/dotnet/aspnetcore/blob/dd7d7772a608c78d44a5cce09627f132f8dad306/src/Localization/Localization/src/ResourceManagerStringLocalizer.cs

ericstj · 2020-10-01T17:15:19Z

Leave out PollyServiceCollectionExtensions -- that's tracked in #4932

pranavkm

Looks good to me.

ericstj · 2020-10-01T17:34:59Z

Sorry about my comments on the validation. @pranavkm it looks like there can be work to clean up those public doc references to internal types and fields.

Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.ResourceManagerStringLocalizer._resourceManager'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.Internal.AssemblyWrapper'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.Internal.IResourceStringProvider'.

pranavkm · 2020-10-01T20:14:34Z

We made some breaking changes in that area during 5.0: aspnet/Announcements#417. Is that what it's complaining about?

xml/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.xml

xml/Microsoft.Extensions.Localization/ResourceNamesCache.xml

xml/Microsoft.Extensions.Localization/StringLocalizer`1.xml

opbld32 · 2020-10-14T06:22:38Z

Docs Build status updates of commit cde5419:

⚠️ Validation status: warnings

File	Status	Preview URL	Details
xml/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.xml	⚠️Warning	View	Details
xml/Microsoft.Extensions.Localization/ResourceNamesCache.xml	✅Succeeded	View
xml/Microsoft.Extensions.Localization/StringLocalizer`1.xml	✅Succeeded	View

xml/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.xml

Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.ResourceManagerStringLocalizer._resourceManager'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.Internal.AssemblyWrapper'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.Internal.IResourceStringProvider'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.Internal.AssemblyWrapper'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.Internal.IResourceStringProvider'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Try searching in the Docs contributor and Admin Guide
See the frequently asked questions
Post your question in the Docs support channel

xml/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.xml

opbld32 · 2020-10-14T21:28:42Z

Docs Build status updates of commit 2e1f44e:

⚠️ Validation status: warnings

File	Status	Preview URL	Details
xml/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.xml	⚠️Warning	View	Details
xml/Microsoft.Extensions.Logging.AzureAppServices/BatchingLoggerProvider.xml	⚠️Warning	View	Details
xml/Microsoft.Extensions.Localization/ResourceNamesCache.xml	✅Succeeded	View
xml/Microsoft.Extensions.Localization/StringLocalizer`1.xml	✅Succeeded	View

xml/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.xml

Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.Internal.AssemblyWrapper'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.Internal.IResourceStringProvider'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.Internal.AssemblyWrapper'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Localization.Internal.IResourceStringProvider'.

xml/Microsoft.Extensions.Logging.AzureAppServices/BatchingLoggerProvider.xml

Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Logging.AzureAppServices.Internal.BatchingLogger'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Logging.AzureAppServices.BatchingLogger'.
Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Logging.AzureAppServices.BatchingLogger'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Try searching in the Docs contributor and Admin Guide
See the frequently asked questions
Post your question in the Docs support channel

maryamariyan · 2020-10-15T01:31:54Z

xml/Microsoft.Extensions.Logging.AzureAppServices/BatchingLoggerProvider.xml

@@ -25,7 +25,7 @@
    </Interface>
  </Interfaces>
  <Docs>
-    <summary>A provider of <see cref="T:Microsoft.Extensions.Logging.AzureAppServices.BatchingLogger" /> instances.</summary>
+    <summary>A provider of <see cref="T:Microsoft.Extensions.Logging.AzureAppServices.Internal.BatchingLogger" /> instances.</summary>


Wondering if comment #4922 (comment) is also relevant here.

Correct. This is the fix based on that comment.

xml/Microsoft.Extensions.Localization/StringLocalizer`1.xml

xml/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.xml

Automatic port of Microsoft.Extensions.Localization docs

6839497

carlossanlop requested review from maryamariyan and ericstj October 1, 2020 01:35

ericstj requested review from pranavkm and ryanbrandenburg and removed request for maryamariyan and ericstj October 1, 2020 17:06

pranavkm approved these changes Oct 1, 2020

View reviewed changes

carlossanlop commented Oct 14, 2020

View reviewed changes

Apply suggestions from code review

cde5419

ryanbrandenburg approved these changes Oct 14, 2020

View reviewed changes

xml/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.xml Show resolved Hide resolved

Fix invalid references, including one missed from a previous PR.

2e1f44e

maryamariyan reviewed Oct 15, 2020

View reviewed changes

maryamariyan approved these changes Oct 15, 2020

View reviewed changes

carlossanlop merged commit bf2bb3e into dotnet:master Oct 15, 2020

carlossanlop deleted the M_E_Localization branch October 15, 2020 16:14

carlossanlop added the area-Extensions-Localization label Mar 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Automatic port of Microsoft.Extensions.Localization docs #4930

Automatic port of Microsoft.Extensions.Localization docs #4930

Uh oh!

carlossanlop commented Oct 1, 2020

Uh oh!

opbld34 commented Oct 1, 2020

Uh oh!

ericstj commented Oct 1, 2020

Uh oh!

ericstj commented Oct 1, 2020

Uh oh!

pranavkm left a comment

Uh oh!

ericstj commented Oct 1, 2020

Uh oh!

pranavkm commented Oct 1, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

opbld32 commented Oct 14, 2020

Uh oh!

Uh oh!

opbld32 commented Oct 14, 2020

Uh oh!

maryamariyan Oct 15, 2020

Uh oh!

carlossanlop Oct 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Automatic port of Microsoft.Extensions.Localization docs #4930

Automatic port of Microsoft.Extensions.Localization docs #4930

Uh oh!

Conversation

carlossanlop commented Oct 1, 2020

Uh oh!

opbld34 commented Oct 1, 2020

⚠️ Validation status: warnings

xml/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.xml

xml/Microsoft.Extensions.DependencyInjection/PollyServiceCollectionExtensions.xml

Uh oh!

ericstj commented Oct 1, 2020

Uh oh!

ericstj commented Oct 1, 2020

Uh oh!

pranavkm left a comment

Choose a reason for hiding this comment

Uh oh!

ericstj commented Oct 1, 2020

Uh oh!

pranavkm commented Oct 1, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

opbld32 commented Oct 14, 2020

⚠️ Validation status: warnings

xml/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.xml

Uh oh!

Uh oh!

opbld32 commented Oct 14, 2020

⚠️ Validation status: warnings

xml/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.xml

xml/Microsoft.Extensions.Logging.AzureAppServices/BatchingLoggerProvider.xml

Uh oh!

maryamariyan Oct 15, 2020

Choose a reason for hiding this comment

Uh oh!

carlossanlop Oct 15, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!