Fix invalid pointer types in ldloca/ldarga descriptions #9574
Conversation
Those are documented to push managed pointers on the stack in the ECMA 335 and the runtime implements them as such.
ghost
added
community-contribution
|
Learn Build status updates of commit 8117734: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
conv.u does not convert managed pointers to transient pointers (type *), so this patch is incorrect. The transient pointers concept was deleted from the standard recently in dotnet/runtime#86622, so any reference to transient pointers should be deleted. There are many more references elsewhere in this file.
|
Tagging @dotnet/area-system-reflection-emit |
|
PTAL @AaronRobinsonMSFT |
Co-authored-by: John Tur <john-tur@outlook.com>
|
Learn Build status updates of commit f1e1045: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
/cc @gewarren |
|
@AaronRobinsonMSFT Is this how it should render? 
|
Definitely not. Let me try again. :) |
|
Learn Build status updates of commit a9f13cd: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@gewarren Should be fixed now. |
Apply #9574 to ldloca.s. --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Summary
Those are documented to push managed pointers on the stack in the ECMA 335 and the runtime implements them as such.