Skip to content

Fix invalid pointer types in ldloca/ldarga descriptions #9574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Fix invalid pointer types in ldloca/ldarga descriptions #9574

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8117734
Fix invalid pointer types in ldloca/ldarga descriptions
MichalPetryka Jan 25, 2024
8d4b84b
Fix typo
MichalPetryka Jan 25, 2024
f1e1045
Apply suggestions from code review
AaronRobinsonMSFT Mar 20, 2024
a9f13cd
Apply suggestions from code review
AaronRobinsonMSFT Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xml/System.Reflection.Emit/OpCodes.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6583,7 +6583,7 @@

1. The address `addr` of the argument indexed by `index` is pushed onto the stack.

The `ldarga` instruction fetches the address (of type `*`) of the argument indexed by `index`, where arguments are indexed from 0 onwards. The address `addr` is always aligned to a natural boundary on the target machine.
The `ldarga` instruction fetches the address (of type `&`) of the argument indexed by `index`, where arguments are indexed from 0 onwards. The address `addr` is always aligned to a natural boundary on the target machine. The argument is stored in unmanaged memory, so the return value can be converted to an unmanaged pointer without pinning.

For procedures that take a variable-length argument list, the `ldarga` instruction can be used only for the initial fixed arguments, not those in the variable part of the signature.

Expand Down Expand Up @@ -10065,7 +10065,7 @@ The following <xref:System.Reflection.Emit.ILGenerator.Emit%2A> method overloads

1. The address stored in the local variable at the specified index is pushed onto the stack.

The `ldloca` instruction pushes the address of the local variable number at the passed index onto the stack, where local variables are numbered 0 onwards. The value pushed on the stack is already aligned correctly for use with instructions like <xref:System.Reflection.Emit.OpCodes.Ldind_I> and <xref:System.Reflection.Emit.OpCodes.Stind_I>. The result is a transient pointer (type `*`).
The `ldloca` instruction pushes the address of the local variable number at the passed index onto the stack, where local variables are numbered 0 onwards. The value pushed on the stack is already aligned correctly for use with instructions like <xref:System.Reflection.Emit.OpCodes.Ldind_I> and <xref:System.Reflection.Emit.OpCodes.Stind_I>. The result is a managed pointer (type `&`). The local variable is stored in unmanaged memory, so the return value can be converted to an unmanaged pointer without pinning.

The following <xref:System.Reflection.Emit.ILGenerator.Emit%2A> method overload can use the `ldloca` opcode:

Expand Down