[release/8.x] Update dependencies from dotnet/arcade

[dotnet-maestro]

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

• Coherency Updates:
  • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23426.1 to 1.0.0-beta.23475.1 (parent: Microsoft.DotNet.Arcade.Sdk)

From https://github.com/dotnet/arcade

• Subscription: 60a1a160-6ffa-4450-1398-08dbcfd3ac55
• Build: 20231016.4
• Date Produced: October 16, 2023 7:28:01 PM UTC
• Commit: 39042b4048580366d35a7c1c4f4ce8fc0dbea4b4
• Branch: refs/heads/release/8.0

• Updates:
  • Microsoft.DotNet.Arcade.Sdk: from 8.0.0-beta.23463.1 to 8.0.0-beta.23516.4
  • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23426.1 to 1.0.0-beta.23475.1

[ghost]

This PR changes the .NET SDK version. Review required from before merging.

[ViktorHofer]

Why is this repository using the UseDotNet AzDO task? Arcade already restores the SDK automatically. cc @mmitche

[jjonescz]

Removed UseDotNet AzDO task, seems it's not needed (and started a signed build to verify it's not needed there either; but it looks like it doesn't work without it).

Now only tests are failing with dotnet/razor#9342:

System.TypeLoadException : Could not load type 'Enumerator' from assembly 'Microsoft.CodeAnalysis, Version=4.8.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'.

Which means we need to wait until VS 17.8P4 is available on CI machines where this problem should be fixed I think.

Plus will probably need to do something similar to this: fc7a9bf.

[ViktorHofer]

Which means we need to wait until VS 17.8P4 is available on CI machines where this problem should be fixed I think.

I think we require VS 17.8 P3 which is currently prepared by the Core Engineering team and should be available later today. @marcpopMSFT / @jaredpar is that right?

[jjonescz]

I think we require VS 17.8 P3 which is currently prepared by the Core Engineering team and should be available later today.

If it works with 17.8P3 then great, but I think regular preview queue will have 17.8P3 and scouting preview queue will have 17.8P4, so we can choose.

[ViktorHofer]

Plus will probably need to do something similar to this: fc7a9bf.

When I last worked on this, I was told that we only want to update the SHAs when there's a reason to do so. The dotnet-format tool must be invoked with the dotnet/format repo's SDK because that's the toolchain that builds the tool. I added this commit a while ago to enforce that requirement: 31d13fa

Unfortunately I just noticed that my changes were undone with the following commits that came in at a later point:

• 08fa79d
• 02779ee

I don't understand why this was done, maybe @JoeRobich can tell?

EDIT: reverted Joe's changes and made it possible to use the parent repo sdk, i.e. for project-system.

[JoeRobich]

I don't understand why this was done, maybe @JoeRobich can tell?

EDIT: reverted Joe's changes and made it possible to use the parent repo sdk, i.e. for project-system.

I made the change when updating MSBuildLocator to v1.6.1. It was having difficulties locating a workable SDK for the integration tests. I see we are on 1.6.10 now, so it may be better behaved.

[jjonescz]

This looks good now but we still need to fix signed builds.

[ViktorHofer]

Should we merge this in meanwhile and fix the remaining issues separately?

[jjonescz]

Merging this would break signed builds for release/8.x so it wouldn't flow into the SDK.

[jjonescz]

Test run of a signed build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2299802&view=results

LGTM