-
Notifications
You must be signed in to change notification settings - Fork 606
Remove obsolete PinNumberingScheme enum and all references #2421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: joperezr <13854455+joperezr@users.noreply.github.com>
Co-authored-by: joperezr <13854455+joperezr@users.noreply.github.com>
cc: @raffaeler @krwq @pgrawehr does this look like what you were expecting? |
@joperezr I didn't review the code yet, but it is definitely a different story! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. A bit surprising how many PinNumberScheme.Board occurences in documentation(!) still had to be removed. But I guess the FTXXX driver didn't really care about that value anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed all the changes and they also looks good to me.
@joperezr after your review, I believe we can merge this. |
Changes look good to me, but I'm curious as to why this isn't throwing build errors due to breaking changes. I'll look into that first before merging. |
…ibility suppressions
Fixes #2387
This PR completely removes the
PinNumberingScheme
enum and all references to it throughout the codebase, as it was obsoleted in the last major release and is no longer needed.Changes Made
Core Library Changes
PinNumberingScheme.cs
entirelyGpioController
:GpioController(PinNumberingScheme numberingScheme)
GpioController(PinNumberingScheme numberingScheme, GpioDriver driver)
NumberingScheme
property fromGpioController
GetLogicalPinNumber()
method to always use logical numbering (no conversion needed)Updated Samples and Documentation
PinNumberingScheme
constructor parametersPinNumberingScheme
referencesAPI Impact
This is a breaking change only for code that was explicitly using the obsolete Board numbering scheme. The vast majority of existing code will continue to work unchanged because:
GpioController()
still works and defaults to logical numberingGpioController(GpioDriver driver)
constructor continues to work as beforeMigration for Board Numbering Users
Users who were using Board numbering can:
Before/After Examples
Before (obsolete usage):
After (recommended usage):
This change eliminates the complexity of dual numbering schemes while maintaining full functionality for the recommended logical numbering approach.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
1k9vsblobprodcus379.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)4vyvsblobprodcus361.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)4zjvsblobprodcus390.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)6s7vsblobprodcus313.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)80zvsblobprodcus35.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)c78vsblobprodcus322.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)ckzvsblobprodcus347.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)dlbvsblobprodcus316.vsblob.vsassets.io
/home/REDACTED/work/iot/iot//.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/iot/iot/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/iot/iot/artifacts/toolset/8.0.0-beta.25378.1.txt
(dns block)/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)/home/REDACTED/work/iot/iot/.dotnet/dotnet build --no-restore --verbosity minimal
(dns block)fdpvsblobprodcus345.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)gbsvsblobprodcus365.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)h6tvsblobprodcus346.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)kh4vsblobprodcus325.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)l49vsblobprodcus358.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)m16vsblobprodcus374.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)m6xvsblobprodcus342.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)o3svsblobprodcus318.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)pe3vsblobprodcus354.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)pkvvsblobprodcus321.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)s4uvsblobprodcus326.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)uy6vsblobprodcus34.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)ytvvsblobprodcus310.vsblob.vsassets.io
/home/REDACTED/work/iot/iot/.dotnet/dotnet build
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Microsoft Reviewers: Open in CodeFlow