Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating OVA tests #2956

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
4 participants
@rogancarr
Copy link
Contributor

rogancarr commented Mar 14, 2019

Fix for OVA #2949 went in without updates to tests. This PR updates the tests to work with the new OVA API.

Fixes: #2955

@ganik

ganik approved these changes Mar 14, 2019

Copy link
Member

ganik left a comment

:shipit:

@rogancarr

This comment has been minimized.

Copy link
Contributor Author

rogancarr commented Mar 14, 2019

This PR updates the OVA test to only test the correct (and working) path.

@TomFinley
Copy link
Contributor

TomFinley left a comment

Thanks @rogancarr. 😄

@shauheen shauheen merged commit 9f87099 into dotnet:master Mar 14, 2019

1 of 3 checks passed

MachineLearning-CI in progress
Details
MachineLearning-CodeCoverage in progress
Details
license/cla All CLA requirements met.
Details
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 14, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@a6a9d9d). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2956   +/-   ##
=========================================
  Coverage          ?   72.25%           
=========================================
  Files             ?      796           
  Lines             ?   142248           
  Branches          ?    16042           
=========================================
  Hits              ?   102788           
  Misses            ?    35081           
  Partials          ?     4379
Flag Coverage Δ
#Debug 72.25% <100%> (?)
#production 68% <ø> (?)
#test 88.39% <100%> (?)
Impacted Files Coverage Δ
test/Microsoft.ML.Functional.Tests/Training.cs 100% <100%> (ø)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.