FlyoutItemIsVisible should accept a "BindableObject" (i.e. it should be data bound) #10960
Labels
area/docs 📓
Conceptual docs, API docs, Samples
area/shell 🐢
Shell Navigation, Routes, Tabs, Flyout
control-flyout
fixed-in-7.0.58
Look for this fix in 7.0.58!
fixed-in-7.0.100
fixed-in-7.0.101
fixed-in-8.0.0-preview.1.7762
Look for this fix in 8.0.0-preview.1.7762!
proposal/open
Milestone
Comments
rachelkang
added
area/docs 📓
|
We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process. |
|
Maybe this is because we have a bad name here? https://github.com/dotnet/maui/blob/main/src/Controls/src/Core/Shell/Shell.cs#L71-L72 public static readonly BindableProperty FlyoutItemIsVisibleProperty =
BindableProperty.CreateAttached(nameof(IsVisible), typeof(bool), typeof(Shell), true, propertyChanged: OnFlyoutItemIsVisibleChanged); |
|
@mattleibow I'm keen for this bug to be fixed, so I've put in a PR with your suggestion (I hope this helps). |
Redth
pushed a commit
that referenced
this issue
Nov 22, 2022
rmarinho
added a commit
that referenced
this issue
Nov 28, 2022
* Update Entry.cs (#11250) Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Revert "[android] bring back `$(AndroidLinkResources)` by default" (#11096) This reverts commit b73147e. Fixes: dotnet/sdk#28880 * Remove dead XML Doc link (#11233) Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * [net7.0] Update dependencies from xamarin/xamarin-macios (#11220) * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221108.30 Microsoft.iOS.Sdk From Version 16.0.1478 -> To Version 16.1.1463 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221108.30 Microsoft.tvOS.Sdk From Version 16.0.1478 -> To Version 16.1.1463 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221108.30 Microsoft.macOS.Sdk From Version 12.3.2372 -> To Version 13.0.2018 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221108.30 Microsoft.MacCatalyst.Sdk From Version 15.4.2372 -> To Version 16.1.1463 * Bump Xcode to 14.1.0 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.4 Microsoft.iOS.Sdk From Version 16.0.1478 -> To Version 16.1.1465 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.4 Microsoft.tvOS.Sdk From Version 16.0.1478 -> To Version 16.1.1465 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.4 Microsoft.macOS.Sdk From Version 12.3.2372 -> To Version 13.0.2020 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.7 Microsoft.iOS.Sdk From Version 16.0.1478 -> To Version 16.1.1466 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.7 Microsoft.tvOS.Sdk From Version 16.0.1478 -> To Version 16.1.1466 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.4 Microsoft.MacCatalyst.Sdk From Version 15.4.2372 -> To Version 16.1.1465 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.7 Microsoft.macOS.Sdk From Version 12.3.2372 -> To Version 13.0.2021 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.7 Microsoft.MacCatalyst.Sdk From Version 15.4.2372 -> To Version 16.1.1466 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.14 Microsoft.iOS.Sdk From Version 16.0.1478 -> To Version 16.1.1467 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.14 Microsoft.tvOS.Sdk From Version 16.0.1478 -> To Version 16.1.1467 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.14 Microsoft.macOS.Sdk From Version 12.3.2372 -> To Version 13.0.2022 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.14 Microsoft.MacCatalyst.Sdk From Version 15.4.2372 -> To Version 16.1.1467 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Alex Soto <alex@alexsoto.me> * restore unittests for native views binding (#11341) * Bump Microsoft.WindowsAppSDK from 1.1.5 to 1.2.221109.1 (#11280) * Bump Microsoft.WindowsAppSDK from 1.1.5 to 1.2.221109.1 Bumps [Microsoft.WindowsAppSDK](https://github.com/microsoft/windowsappsdk) from 1.1.5 to 1.2.221109.1. - [Release notes](https://github.com/microsoft/windowsappsdk/releases) - [Commits](https://github.com/microsoft/windowsappsdk/commits) --- updated-dependencies: - dependency-name: Microsoft.WindowsAppSDK dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update Directory.Build.targets Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> * Bump Microsoft.CodeAnalysis.CSharp from 4.2.0 to 4.4.0 (#11365) Bumps [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn) from 4.2.0 to 4.4.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v4.2.0...Visual-Studio-2019-Version-16.0-Preview-4.4) --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Xamarin.Build.Download from 0.11.3 to 0.11.4 (#11367) Bumps [Xamarin.Build.Download](https://github.com/xamarin/XamarinComponents) from 0.11.3 to 0.11.4. - [Release notes](https://github.com/xamarin/XamarinComponents/releases) - [Commits](https://github.com/xamarin/XamarinComponents/commits) --- updated-dependencies: - dependency-name: Xamarin.Build.Download dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.Net.Compilers.Toolset from 4.3.1 to 4.4.0 (#11366) Bumps [Microsoft.Net.Compilers.Toolset](https://github.com/dotnet/roslyn) from 4.3.1 to 4.4.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits/Visual-Studio-2019-Version-16.0-Preview-4.4) --- updated-dependencies: - dependency-name: Microsoft.Net.Compilers.Toolset dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Set window soft input via window mapper (#11356) * Set window soft input via window mapper * - disconnect handlers * - add additional logging info * - fix handler typing * - fix formatting * Update Microsoft.Windows.SDK.BuildTools (#11396) * Update Versions.props * Not needed anymore! * Revert "Not needed anymore!" This reverts commit 1e22ff2. * Bump Xamarin.UITest from 3.2.9 to 4.0.0 (#11407) Bumps Xamarin.UITest from 3.2.9 to 4.0.0. --- updated-dependencies: - dependency-name: Xamarin.UITest dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/xharness build 20221108.1 (#11342) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.22531.1 -> To Version 1.0.0-prerelease.22558.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [main] Update dependencies from xamarin/xamarin-macios (#11338) * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221114.10 Microsoft.MacCatalyst.Sdk From Version 15.4.2372 -> To Version 16.1.1468 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221115.12 Microsoft.iOS.Sdk From Version 16.1.1467 -> To Version 16.1.1469 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221115.12 Microsoft.tvOS.Sdk From Version 16.1.1467 -> To Version 16.1.1469 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221115.12 Microsoft.macOS.Sdk From Version 13.0.2022 -> To Version 13.0.2024 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221115.12 Microsoft.MacCatalyst.Sdk From Version 16.1.1467 -> To Version 16.1.1469 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> * Add NeedsExactMeasure check for Editor on Android (#10876) * Add NeedsExactMeasure check for Editor on Android Fixes #8232 Fixes #7627 * Add public API stuff * Update Essentials Barometer API Docs (#11378) * Update Essentials Barometer API Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials AppActions API Docs (#11373) * Fix Essentials AppActions API Docs * Update AppActions.netstandard.tvos.watchos.macos.tizen.cs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials Accelerometer API Docs (#11370) * External file to inline * Final touches * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Remove unnecessary MeasureOverride from RefreshView; (#11357) * Remove unnecessary MeasureOverride from RefreshView; Fixes #5772 * Fix missing api thing * Don't set editor action to handled (#11386) * Don't set editor action to handled * - Add tests * - remove for tizen * Update Essentials Battery API Docs (#11380) * Update Essentials Battery API Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials AppInfo API Docs (#11374) * Update Essentials AppInfo API Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials Browser API Docs (#11394) * Update Essentials Browser API Docs * Apply suggestions from code review All the URI! Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * [iOS] Fix issue clearing MapElements in Map (#11471) Fixes #11296 * Fix issue clearing MapElements in iOS Map * Fix XAML formatting * Update Essentials Contacts API Docs (#11417) * Update Essentials Contacts API Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials Connectivity API Docs (#11415) * Update Essentials Connectivity API Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials Clipboard Docs (#11395) * Update Essentials Clipboard Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Fix window page changed event subscriptions (#11483) * Fix the ordering registration for tests (#11484) * Fix the ordering registration for tests * - fix the timing on some tests * CodeQL only on main/non-public builds (#11273) * CodeQL only on main/non-public builds * Update eng/pipelines/common/variables.yml Co-authored-by: Rui Marinho <me@ruimarinho.net> * Update dependencies from https://github.com/dotnet/xharness build 20221119.1 (#11524) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.22558.1 -> To Version 1.0.0-prerelease.22569.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Ensure that UIScrollView ContentSize is set (#11175) * Ensure that UIScrollView ContentSize is set; Fixes #9209; also fixes #11017. * Use EnsureHandlerCreated in tests * Make unbounded arrange method public; move UIScrollView ContentSize test to Controls; Write new ContentSize test in Core; * Fix public api stuff * Fix iOS/macOS Images not cropped inside of a Frame #6580 (#11352) * Enable Frame to clip children content on ios by default * use tryget properly * fix formatting * Reverting bool check since it is nullable * use the correct bindable property * use an extension method to share code for frame * changing the extension method to internal Co-authored-by: TJ Lambert <tjlambert@microsoft.com> * [Build] Clean up provisioning script (#11523) * [Build] Clean up provisioning script * Fix openjdk only on Mac * [Housekeeping] Remove calls to Console.WriteLine to decrease app size (#11437) Fixes #11405 * Remove calls to Console.WriteLine to decrease app size * Update src/Core/src/Handlers/WebView/WebViewHandler.iOS.cs Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com> Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com> * Clean up the files in the xml-docs artifacts (#11257) * Update dotnet.cake * Update dotnet.cake * Update dotnet.cake * Update dotnet.cake * Add BlazorWebView, enable Graphics docs gen * Filter DesignTools assembly * Include BlazorWebView * Remove BlazorWebView * [foldable] add TypeConverter to Pane1Length/Pane2Length properties (#11269) fixes #11240 * [Tizen] Add handing Label.TextType (#11389) * Add .NET 7 announcement (#11539) * [Tizen] Add Shell FlyoutBackDrop (#11390) * Bump Microsoft.WindowsAppSDK from 1.2.221109.1 to 1.2.221116.1 (#11469) Bumps [Microsoft.WindowsAppSDK](https://github.com/microsoft/windowsappsdk) from 1.2.221109.1 to 1.2.221116.1. - [Release notes](https://github.com/microsoft/windowsappsdk/releases) - [Commits](https://github.com/microsoft/windowsappsdk/commits) --- updated-dependencies: - dependency-name: Microsoft.WindowsAppSDK dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Allow transparent modal pages on iOS (#11107) Fixes #8526 Fixes #11040 * Update Essentials DeviceInfo API Docs (#11431) * Update Essentials DeviceInfo API Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials DeviceDisplay API Docs (#11429) * Update Essentials DeviceDisplay API Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Possible fix for issue #10960 (#11361) * Possible fix for issue #10960 * Update src/Controls/src/Core/Shell/Shell.cs Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> * Bump Microsoft.Bcl.AsyncInterfaces from 6.0.0 to 7.0.0 (#11193) * Bump Microsoft.Bcl.AsyncInterfaces from 6.0.0 to 7.0.0 Bumps [Microsoft.Bcl.AsyncInterfaces](https://github.com/dotnet/runtime) from 6.0.0 to 7.0.0. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](https://github.com/dotnet/runtime/commits) --- updated-dependencies: - dependency-name: Microsoft.Bcl.AsyncInterfaces dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump System.Text.Json Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> * Reboot on-prem agent after job completion (#11359) * Reboot on-prem Mac agent at the end of a test run * Use agent-rebooter template capable of targeting the xamarin org * Simplify agent-rebooter condition to only include the agent pool check * Diagnostics: Show agent agentPool parameter setting * Powershell block step * Diagnostics: Single line echo statement * Test: Simplify output to not include parameter setting * Pass through the agent pool name rather than the pool object * Show agent pool at the beginning of the job * Remove agentPoolName parameter and condition The agent-rebooter template will only take action when the agent is in an on-prem pool. It will not attempt to reboot an agent in a hosted pool * Try placing group Xamarin-Secrets after the variables template * Xamarin-Secrets is already included in the variables template * Directly use the Xamarin public pool access token keyvault value * Capture the agent pool access token in a variable * Move AgentPoolAccessToken definition into device-tests * Updated rebooter template eliminates need for organization and project parameters * Temporarily remove all steps except the rebooter * Restore the original steps * Focus testing on the rebooter * Restore all steps * Comment noting that the rebooter template must always be the last step in the job * Agent-rebooter capability was released to production and so target in yaml-templates main * Trim trailing whitespace * [main] Update dependencies from xamarin/xamarin-macios (#11553) * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.6 Microsoft.iOS.Sdk From Version 16.1.1469 -> To Version 16.1.1474 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.6 Microsoft.tvOS.Sdk From Version 16.1.1469 -> To Version 16.1.1474 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.6 Microsoft.macOS.Sdk From Version 13.0.2024 -> To Version 13.0.2029 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.6 Microsoft.MacCatalyst.Sdk From Version 16.1.1469 -> To Version 16.1.1474 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Dotnet format Microsoft.Maui.sln (#11110) * Notify Button ImageSource changes correctly (#11146) * Fix the issue * Added Device Tests * [Android] Fix Stepper IsEnabled property changes (#11053) * Added sample to validate the issue * Fix droid Stepper IsEnabled property * Added Device Test * [main] Update dependencies from xamarin/xamarin-macios (#11563) * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.14 Microsoft.iOS.Sdk From Version 16.1.1474 -> To Version 16.1.1475 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.14 Microsoft.tvOS.Sdk From Version 16.1.1474 -> To Version 16.1.1475 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.14 Microsoft.macOS.Sdk From Version 13.0.2029 -> To Version 13.0.2030 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.14 Microsoft.MacCatalyst.Sdk From Version 16.1.1474 -> To Version 16.1.1475 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.17 Microsoft.tvOS.Sdk From Version 16.1.1474 -> To Version 16.1.1477 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.17 Microsoft.macOS.Sdk From Version 13.0.2029 -> To Version 13.0.2032 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.17 Microsoft.MacCatalyst.Sdk From Version 16.1.1474 -> To Version 16.1.1477 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.17 Microsoft.iOS.Sdk From Version 16.1.1474 -> To Version 16.1.1477 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.16 Microsoft.iOS.Sdk From Version 16.1.1474 -> To Version 16.1.1476 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.16 Microsoft.tvOS.Sdk From Version 16.1.1474 -> To Version 16.1.1476 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.16 Microsoft.macOS.Sdk From Version 13.0.2029 -> To Version 13.0.2031 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.16 Microsoft.MacCatalyst.Sdk From Version 16.1.1474 -> To Version 16.1.1476 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Bump autoformatting action to v0.2. (#11580) This new and shiny version is able to just autoformat files already modified in a PR, so enable that mode. * Fix ObjectDisposedException on Android resizing images (#11577) * [Android] Fix crash using Page IsBusy property (#9783) * Fix IsBusy crash on Android * Added Device Test * Align Shapes Fill property behavior with Xamarin.Forms (#10328) * Align Shapes Fill property behavior with Xamarin.Forms * Added device tests * Fix brushes in Frame (#7925) * Fix Managing Layout Children (#11581) * Avoid propagate Map tap event tapping a Pin on iOS (#11582) Fixes #11532 * Exclude incompatible files from daily dotnet format workflow (#11590) Some C# files use '#if' to include/exclude code and that does not work well with the dotnet format command. * Only include MauiXaml/Css when $(UseMaui)=true (#11638) * Add appropriate versioning attributes (#11589) * Add a condition to skip the AutoImport.props (#11665) Adding '$(_MauiSkipSdkAutoImport)' != 'true' so that the imports can be skipped * [Build] Update yaml for net8 (#11609) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Alex Soto <alex@alexsoto.me> Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Jonathan Dick <jondick@gmail.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> Co-authored-by: TJ Lambert <tjlambert@microsoft.com> Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com> Co-authored-by: Craig Dunn <craig.dunn@microsoft.com> Co-authored-by: Jay Cho <chojoong@gmail.com> Co-authored-by: Richard Garside <code@nogginbox.co.uk> Co-authored-by: Mike Bond <mjbond-msft@outlook.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: Rachel Kang <rachelkang@microsoft.com>
Redth
pushed a commit
that referenced
this issue
Dec 5, 2022
* Possible fix for issue #10960 * Update src/Controls/src/Core/Shell/Shell.cs Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Richard Garside <code@nogginbox.co.uk> Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
rmarinho
added a commit
that referenced
this issue
Dec 12, 2022
* Update Entry.cs (#11250) Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Revert "[android] bring back `$(AndroidLinkResources)` by default" (#11096) This reverts commit b73147e. Fixes: dotnet/sdk#28880 * Remove dead XML Doc link (#11233) Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * [net7.0] Update dependencies from xamarin/xamarin-macios (#11220) * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221108.30 Microsoft.iOS.Sdk From Version 16.0.1478 -> To Version 16.1.1463 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221108.30 Microsoft.tvOS.Sdk From Version 16.0.1478 -> To Version 16.1.1463 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221108.30 Microsoft.macOS.Sdk From Version 12.3.2372 -> To Version 13.0.2018 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221108.30 Microsoft.MacCatalyst.Sdk From Version 15.4.2372 -> To Version 16.1.1463 * Bump Xcode to 14.1.0 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.4 Microsoft.iOS.Sdk From Version 16.0.1478 -> To Version 16.1.1465 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.4 Microsoft.tvOS.Sdk From Version 16.0.1478 -> To Version 16.1.1465 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.4 Microsoft.macOS.Sdk From Version 12.3.2372 -> To Version 13.0.2020 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.7 Microsoft.iOS.Sdk From Version 16.0.1478 -> To Version 16.1.1466 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.7 Microsoft.tvOS.Sdk From Version 16.0.1478 -> To Version 16.1.1466 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.4 Microsoft.MacCatalyst.Sdk From Version 15.4.2372 -> To Version 16.1.1465 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.7 Microsoft.macOS.Sdk From Version 12.3.2372 -> To Version 13.0.2021 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.7 Microsoft.MacCatalyst.Sdk From Version 15.4.2372 -> To Version 16.1.1466 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.14 Microsoft.iOS.Sdk From Version 16.0.1478 -> To Version 16.1.1467 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.14 Microsoft.tvOS.Sdk From Version 16.0.1478 -> To Version 16.1.1467 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.14 Microsoft.macOS.Sdk From Version 12.3.2372 -> To Version 13.0.2022 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221111.14 Microsoft.MacCatalyst.Sdk From Version 15.4.2372 -> To Version 16.1.1467 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Alex Soto <alex@alexsoto.me> * restore unittests for native views binding (#11341) * Bump Microsoft.WindowsAppSDK from 1.1.5 to 1.2.221109.1 (#11280) * Bump Microsoft.WindowsAppSDK from 1.1.5 to 1.2.221109.1 Bumps [Microsoft.WindowsAppSDK](https://github.com/microsoft/windowsappsdk) from 1.1.5 to 1.2.221109.1. - [Release notes](https://github.com/microsoft/windowsappsdk/releases) - [Commits](https://github.com/microsoft/windowsappsdk/commits) --- updated-dependencies: - dependency-name: Microsoft.WindowsAppSDK dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update Directory.Build.targets Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> * Bump Microsoft.CodeAnalysis.CSharp from 4.2.0 to 4.4.0 (#11365) Bumps [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn) from 4.2.0 to 4.4.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v4.2.0...Visual-Studio-2019-Version-16.0-Preview-4.4) --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Xamarin.Build.Download from 0.11.3 to 0.11.4 (#11367) Bumps [Xamarin.Build.Download](https://github.com/xamarin/XamarinComponents) from 0.11.3 to 0.11.4. - [Release notes](https://github.com/xamarin/XamarinComponents/releases) - [Commits](https://github.com/xamarin/XamarinComponents/commits) --- updated-dependencies: - dependency-name: Xamarin.Build.Download dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.Net.Compilers.Toolset from 4.3.1 to 4.4.0 (#11366) Bumps [Microsoft.Net.Compilers.Toolset](https://github.com/dotnet/roslyn) from 4.3.1 to 4.4.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits/Visual-Studio-2019-Version-16.0-Preview-4.4) --- updated-dependencies: - dependency-name: Microsoft.Net.Compilers.Toolset dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Set window soft input via window mapper (#11356) * Set window soft input via window mapper * - disconnect handlers * - add additional logging info * - fix handler typing * - fix formatting * Update Microsoft.Windows.SDK.BuildTools (#11396) * Update Versions.props * Not needed anymore! * Revert "Not needed anymore!" This reverts commit 1e22ff2. * Bump Xamarin.UITest from 3.2.9 to 4.0.0 (#11407) Bumps Xamarin.UITest from 3.2.9 to 4.0.0. --- updated-dependencies: - dependency-name: Xamarin.UITest dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/xharness build 20221108.1 (#11342) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.22531.1 -> To Version 1.0.0-prerelease.22558.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [main] Update dependencies from xamarin/xamarin-macios (#11338) * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221114.10 Microsoft.MacCatalyst.Sdk From Version 15.4.2372 -> To Version 16.1.1468 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221115.12 Microsoft.iOS.Sdk From Version 16.1.1467 -> To Version 16.1.1469 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221115.12 Microsoft.tvOS.Sdk From Version 16.1.1467 -> To Version 16.1.1469 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221115.12 Microsoft.macOS.Sdk From Version 13.0.2022 -> To Version 13.0.2024 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221115.12 Microsoft.MacCatalyst.Sdk From Version 16.1.1467 -> To Version 16.1.1469 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> * Add NeedsExactMeasure check for Editor on Android (#10876) * Add NeedsExactMeasure check for Editor on Android Fixes #8232 Fixes #7627 * Add public API stuff * Update Essentials Barometer API Docs (#11378) * Update Essentials Barometer API Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials AppActions API Docs (#11373) * Fix Essentials AppActions API Docs * Update AppActions.netstandard.tvos.watchos.macos.tizen.cs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials Accelerometer API Docs (#11370) * External file to inline * Final touches * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Remove unnecessary MeasureOverride from RefreshView; (#11357) * Remove unnecessary MeasureOverride from RefreshView; Fixes #5772 * Fix missing api thing * Don't set editor action to handled (#11386) * Don't set editor action to handled * - Add tests * - remove for tizen * Update Essentials Battery API Docs (#11380) * Update Essentials Battery API Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials AppInfo API Docs (#11374) * Update Essentials AppInfo API Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials Browser API Docs (#11394) * Update Essentials Browser API Docs * Apply suggestions from code review All the URI! Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * [iOS] Fix issue clearing MapElements in Map (#11471) Fixes #11296 * Fix issue clearing MapElements in iOS Map * Fix XAML formatting * Update Essentials Contacts API Docs (#11417) * Update Essentials Contacts API Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials Connectivity API Docs (#11415) * Update Essentials Connectivity API Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials Clipboard Docs (#11395) * Update Essentials Clipboard Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Fix window page changed event subscriptions (#11483) * Fix the ordering registration for tests (#11484) * Fix the ordering registration for tests * - fix the timing on some tests * CodeQL only on main/non-public builds (#11273) * CodeQL only on main/non-public builds * Update eng/pipelines/common/variables.yml Co-authored-by: Rui Marinho <me@ruimarinho.net> * Update dependencies from https://github.com/dotnet/xharness build 20221119.1 (#11524) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.22558.1 -> To Version 1.0.0-prerelease.22569.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Ensure that UIScrollView ContentSize is set (#11175) * Ensure that UIScrollView ContentSize is set; Fixes #9209; also fixes #11017. * Use EnsureHandlerCreated in tests * Make unbounded arrange method public; move UIScrollView ContentSize test to Controls; Write new ContentSize test in Core; * Fix public api stuff * Fix iOS/macOS Images not cropped inside of a Frame #6580 (#11352) * Enable Frame to clip children content on ios by default * use tryget properly * fix formatting * Reverting bool check since it is nullable * use the correct bindable property * use an extension method to share code for frame * changing the extension method to internal Co-authored-by: TJ Lambert <tjlambert@microsoft.com> * [Build] Clean up provisioning script (#11523) * [Build] Clean up provisioning script * Fix openjdk only on Mac * [Housekeeping] Remove calls to Console.WriteLine to decrease app size (#11437) Fixes #11405 * Remove calls to Console.WriteLine to decrease app size * Update src/Core/src/Handlers/WebView/WebViewHandler.iOS.cs Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com> Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com> * Clean up the files in the xml-docs artifacts (#11257) * Update dotnet.cake * Update dotnet.cake * Update dotnet.cake * Update dotnet.cake * Add BlazorWebView, enable Graphics docs gen * Filter DesignTools assembly * Include BlazorWebView * Remove BlazorWebView * [foldable] add TypeConverter to Pane1Length/Pane2Length properties (#11269) fixes #11240 * [Tizen] Add handing Label.TextType (#11389) * Add .NET 7 announcement (#11539) * [Tizen] Add Shell FlyoutBackDrop (#11390) * Bump Microsoft.WindowsAppSDK from 1.2.221109.1 to 1.2.221116.1 (#11469) Bumps [Microsoft.WindowsAppSDK](https://github.com/microsoft/windowsappsdk) from 1.2.221109.1 to 1.2.221116.1. - [Release notes](https://github.com/microsoft/windowsappsdk/releases) - [Commits](https://github.com/microsoft/windowsappsdk/commits) --- updated-dependencies: - dependency-name: Microsoft.WindowsAppSDK dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Allow transparent modal pages on iOS (#11107) Fixes #8526 Fixes #11040 * Update Essentials DeviceInfo API Docs (#11431) * Update Essentials DeviceInfo API Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials DeviceDisplay API Docs (#11429) * Update Essentials DeviceDisplay API Docs * Apply suggestions from code review Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Possible fix for issue #10960 (#11361) * Possible fix for issue #10960 * Update src/Controls/src/Core/Shell/Shell.cs Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> * Bump Microsoft.Bcl.AsyncInterfaces from 6.0.0 to 7.0.0 (#11193) * Bump Microsoft.Bcl.AsyncInterfaces from 6.0.0 to 7.0.0 Bumps [Microsoft.Bcl.AsyncInterfaces](https://github.com/dotnet/runtime) from 6.0.0 to 7.0.0. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](https://github.com/dotnet/runtime/commits) --- updated-dependencies: - dependency-name: Microsoft.Bcl.AsyncInterfaces dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump System.Text.Json Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> * Reboot on-prem agent after job completion (#11359) * Reboot on-prem Mac agent at the end of a test run * Use agent-rebooter template capable of targeting the xamarin org * Simplify agent-rebooter condition to only include the agent pool check * Diagnostics: Show agent agentPool parameter setting * Powershell block step * Diagnostics: Single line echo statement * Test: Simplify output to not include parameter setting * Pass through the agent pool name rather than the pool object * Show agent pool at the beginning of the job * Remove agentPoolName parameter and condition The agent-rebooter template will only take action when the agent is in an on-prem pool. It will not attempt to reboot an agent in a hosted pool * Try placing group Xamarin-Secrets after the variables template * Xamarin-Secrets is already included in the variables template * Directly use the Xamarin public pool access token keyvault value * Capture the agent pool access token in a variable * Move AgentPoolAccessToken definition into device-tests * Updated rebooter template eliminates need for organization and project parameters * Temporarily remove all steps except the rebooter * Restore the original steps * Focus testing on the rebooter * Restore all steps * Comment noting that the rebooter template must always be the last step in the job * Agent-rebooter capability was released to production and so target in yaml-templates main * Trim trailing whitespace * [main] Update dependencies from xamarin/xamarin-macios (#11553) * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.6 Microsoft.iOS.Sdk From Version 16.1.1469 -> To Version 16.1.1474 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.6 Microsoft.tvOS.Sdk From Version 16.1.1469 -> To Version 16.1.1474 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.6 Microsoft.macOS.Sdk From Version 13.0.2024 -> To Version 13.0.2029 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.6 Microsoft.MacCatalyst.Sdk From Version 16.1.1469 -> To Version 16.1.1474 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Dotnet format Microsoft.Maui.sln (#11110) * Notify Button ImageSource changes correctly (#11146) * Fix the issue * Added Device Tests * [Android] Fix Stepper IsEnabled property changes (#11053) * Added sample to validate the issue * Fix droid Stepper IsEnabled property * Added Device Test * [main] Update dependencies from xamarin/xamarin-macios (#11563) * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.14 Microsoft.iOS.Sdk From Version 16.1.1474 -> To Version 16.1.1475 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.14 Microsoft.tvOS.Sdk From Version 16.1.1474 -> To Version 16.1.1475 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.14 Microsoft.macOS.Sdk From Version 13.0.2029 -> To Version 13.0.2030 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.14 Microsoft.MacCatalyst.Sdk From Version 16.1.1474 -> To Version 16.1.1475 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.17 Microsoft.tvOS.Sdk From Version 16.1.1474 -> To Version 16.1.1477 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.17 Microsoft.macOS.Sdk From Version 13.0.2029 -> To Version 13.0.2032 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.17 Microsoft.MacCatalyst.Sdk From Version 16.1.1474 -> To Version 16.1.1477 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.17 Microsoft.iOS.Sdk From Version 16.1.1474 -> To Version 16.1.1477 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.16 Microsoft.iOS.Sdk From Version 16.1.1474 -> To Version 16.1.1476 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.16 Microsoft.tvOS.Sdk From Version 16.1.1474 -> To Version 16.1.1476 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.16 Microsoft.macOS.Sdk From Version 13.0.2029 -> To Version 13.0.2031 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221122.16 Microsoft.MacCatalyst.Sdk From Version 16.1.1474 -> To Version 16.1.1476 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Bump autoformatting action to v0.2. (#11580) This new and shiny version is able to just autoformat files already modified in a PR, so enable that mode. * Fix ObjectDisposedException on Android resizing images (#11577) * [Android] Fix crash using Page IsBusy property (#9783) * Fix IsBusy crash on Android * Added Device Test * Align Shapes Fill property behavior with Xamarin.Forms (#10328) * Align Shapes Fill property behavior with Xamarin.Forms * Added device tests * Fix brushes in Frame (#7925) * Fix Managing Layout Children (#11581) * Avoid propagate Map tap event tapping a Pin on iOS (#11582) Fixes #11532 * Exclude incompatible files from daily dotnet format workflow (#11590) Some C# files use '#if' to include/exclude code and that does not work well with the dotnet format command. * Only include MauiXaml/Css when $(UseMaui)=true (#11638) * Add appropriate versioning attributes (#11589) * Add a condition to skip the AutoImport.props (#11665) Adding '$(_MauiSkipSdkAutoImport)' != 'true' so that the imports can be skipped * Fix MauiIcon ForegroundScale on systems with comma as decimal separator Fixes #11685 Specifying the ForegroundScale with a dot caused an issue on systems with commas as decimal separators. The image got upscaled instead of downscaled on those systems because the ForegroundScale was parsed without passing InvariantCulture as culture info. Because of this, it only worked on systems with a dot as a decimal separator. * [Build] Update yaml for net8 (#11609) * Make iOS Label HTML behavior compatible with Forms (#11569) Fixes #4230 * Make iOS Label HTML behavior compatible with Forms Fixes #4230 * Fix usings * _itemsSource may be null in CarouselViewLoopManager (#11000) * _itemsSource may be null I'm seeing a NullReferenceException in this method. There are no guards against `_itemsSource` being null, so dereferencing it to get its `Count` seems likely to be the problem. * fix dropped semicolon Co-authored-by: redth <jondick@gmail.com> * [create-pull-request] automated change (#11671) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix issue loading local files in iOS WebView (#10804) * [iOS] RadioButton a11y (#10832) * First attempt of radiobutton a11y * Make Switch trait work as expected * Update control gallery sample * Make class internal for potential backport * Update based on feedback * Add comment * Update based on feedback * [main] Update dependencies from xamarin/xamarin-macios (#11696) * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221128.2 Microsoft.iOS.Sdk From Version 16.1.1476 -> To Version 16.1.1478 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221128.2 Microsoft.tvOS.Sdk From Version 16.1.1476 -> To Version 16.1.1478 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221128.2 Microsoft.macOS.Sdk From Version 13.0.2031 -> To Version 13.0.2033 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221128.2 Microsoft.MacCatalyst.Sdk From Version 16.1.1476 -> To Version 16.1.1478 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Using local function to fix multi-thread issues (#11497) Fixes #11321 * [create-pull-request] automated change (#11713) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [main] Update dependencies from xamarin/xamarin-macios (#11734) * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221129.20 Microsoft.iOS.Sdk From Version 16.1.1478 -> To Version 16.1.1479 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221129.20 Microsoft.tvOS.Sdk From Version 16.1.1478 -> To Version 16.1.1479 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221129.20 Microsoft.macOS.Sdk From Version 13.0.2033 -> To Version 13.0.2034 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221129.20 Microsoft.MacCatalyst.Sdk From Version 16.1.1478 -> To Version 16.1.1479 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221129.22 Microsoft.iOS.Sdk From Version 16.1.1478 -> To Version 16.1.1480 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221129.22 Microsoft.tvOS.Sdk From Version 16.1.1478 -> To Version 16.1.1480 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221129.22 Microsoft.macOS.Sdk From Version 13.0.2033 -> To Version 13.0.2035 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221129.22 Microsoft.MacCatalyst.Sdk From Version 16.1.1478 -> To Version 16.1.1480 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [WinUI] Fix RefreshView crash if no content is specified (#11735) * Ensure invisible views don't get rows/columns when generating AndExpand layouts (#11712) * Ensure invisible views don't get rows/columns when generating AndExpand layouts Fixes #11678 * Auto-format source code * Add test for things becoming visible again Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com> * Fix Element.ChildRemoved event sender (#11741) Fixes #11720 * Pass correct event source * Update ElementTests.cs * Update ElementTests.cs * [main] Fix up the Shipped/Unshipped APIs * Mark the API changes as unshipped * Correctly disable MenuBarItems on Windows (#11695) * Notify StrokeDashPattern changes with StrokeDashArray changes (#11694) * Invalidate Button background drawable if size changes (#11604) * Add API changes doc (#11768) * Add API changes doc * spelling * more words * try this now * = * sadf * Update docs/design/APIChangeTracking.md Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com> * Update docs/design/APIChangeTracking.md Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com> * Update docs/design/APIChangeTracking.md Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com> * Update docs/design/APIChangeTracking.md Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com> * Update APIChangeTracking.md Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com> Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com> * [build] Add support for Visual Studio on win-arm64 (#11803) Context: #11090 Context: xamarin/yaml-templates#204 Context: xamarin/xamarin-android#7471 Context: xamarin/xamarin-macios#16935 Updates the VSMAN files generated for our .NET workload to support Visual Studio on windows-arm64. * Update templates to have separate default for framework selection (#11034) * Update ide.host.json * Update ide.host.json * Update ide.host.json * ws Co-authored-by: Matthew Leibowitz <mattleibow@live.com> * Add maestro-changelog workflow action (#11757) * Bump Xamarin.UITest from 4.0.0 to 4.0.1 (#11826) Bumps Xamarin.UITest from 4.0.0 to 4.0.1. --- updated-dependencies: - dependency-name: Xamarin.UITest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Reconcile PointerOver, Pressed, and Focused states (#11840) * Potential fix for #9753 on desktop * Fix test for release disabled button * Fix test for release disabled button * Add more tests; fix issues with "stuck" PointerOver states * Clean up extraneous debug stuff * D'oh * Add empty PointerOver states to Buttons to reduce confusion (#11842) We've had multiple users run into issues with the Pressed VisualState on Buttons (see #9715 and #8309) - they set up a Pressed state, and then are confused when the state remains after releasing the Button. This is happening* because the Button is moving into the PointerOver state, which does not exist in their VisualState lists. Since the target state is not found, the Pressed state remains in effect until the user leaves the PointerOver state. This is similar to the behavior of a Pressed state with no PointerOver state defined in UWP/WinUI. The solution is to define a PointerOver state. To reduce confusion, we should just add a PointerOver state to our default templates. * At the time these bugs were originally opened, the problem was likely the Focused state, because PointerOver didn't exist yet. But in the most recent release, PointerOver replaces Focused as the source of the problem; the Focused issue is dealt with by #11840. * Remove Android LaunchAdjacent flag for Essentials (#11783) * [create-pull-request] automated change (#11775) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [main] Update dependencies from xamarin/xamarin-macios (#11765) * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221130.1 Microsoft.iOS.Sdk From Version 16.1.1480 -> To Version 16.1.1481 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221130.1 Microsoft.tvOS.Sdk From Version 16.1.1480 -> To Version 16.1.1481 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221130.1 Microsoft.macOS.Sdk From Version 13.0.2035 -> To Version 13.0.2036 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221130.1 Microsoft.MacCatalyst.Sdk From Version 16.1.1480 -> To Version 16.1.1481 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221201.7 Microsoft.iOS.Sdk From Version 16.1.1480 -> To Version 16.1.1483 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221201.7 Microsoft.tvOS.Sdk From Version 16.1.1480 -> To Version 16.1.1483 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221201.7 Microsoft.macOS.Sdk From Version 13.0.2035 -> To Version 13.0.2038 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221201.7 Microsoft.MacCatalyst.Sdk From Version 16.1.1480 -> To Version 16.1.1483 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221202.4 Microsoft.iOS.Sdk From Version 16.1.1480 -> To Version 16.1.1485 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221202.2 Microsoft.iOS.Sdk From Version 16.1.1480 -> To Version 16.1.1484 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221202.4 Microsoft.tvOS.Sdk From Version 16.1.1480 -> To Version 16.1.1485 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221202.2 Microsoft.tvOS.Sdk From Version 16.1.1480 -> To Version 16.1.1484 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221202.4 Microsoft.macOS.Sdk From Version 13.0.2035 -> To Version 13.0.2040 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221202.2 Microsoft.macOS.Sdk From Version 13.0.2035 -> To Version 13.0.2039 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221202.4 Microsoft.MacCatalyst.Sdk From Version 16.1.1480 -> To Version 16.1.1485 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221202.2 Microsoft.MacCatalyst.Sdk From Version 16.1.1480 -> To Version 16.1.1484 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [Build] Remove unused variable (#11727) * Remove unused variable * Auto-format source code * Cleanup provisioning * Use variable for skipping provisioning * Try other approach Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com> * [build] Fix changelog workflow (#11895) * [create-pull-request] automated change (#11888) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [main] Update dependencies from xamarin/xamarin-macios (#11892) * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221206.4 Microsoft.iOS.Sdk From Version 16.1.1484 -> To Version 16.1.1487 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221206.4 Microsoft.tvOS.Sdk From Version 16.1.1484 -> To Version 16.1.1487 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221206.4 Microsoft.macOS.Sdk From Version 13.0.2039 -> To Version 13.0.2042 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20221206.4 Microsoft.MacCatalyst.Sdk From Version 16.1.1484 -> To Version 16.1.1487 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Bump Microsoft.Web.WebView2 from 1.0.1418.22 to 1.0.1462.37 (#11898) Bumps Microsoft.Web.WebView2 from 1.0.1418.22 to 1.0.1462.37. --- updated-dependencies: - dependency-name: Microsoft.Web.WebView2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Only add PointerGesture if PointerOver VisualState exists (#11591) * Don't add PGR if user hasn't added PointerOver * - apply PR comments * Update src/Controls/src/Core/VisualStateManager.cs Co-authored-by: Rachel Kang <rachelkang@microsoft.com> * Update VisualStateManager.cs * Update src/Controls/tests/Core.UnitTests/PointerGestureRecognizerTests.cs Co-authored-by: Rachel Kang <rachelkang@microsoft.com> * Update src/TestUtils/src/DeviceTests/AssertionExtensions.iOS.cs Co-authored-by: Rachel Kang <rachelkang@microsoft.com> * Update src/TestUtils/src/DeviceTests/AssertionExtensions.iOS.cs Co-authored-by: Rachel Kang <rachelkang@microsoft.com> * Update src/TestUtils/src/DeviceTests/AssertionExtensions.iOS.cs Co-authored-by: Rachel Kang <rachelkang@microsoft.com> * Update AccessibilityTests.cs * Update VisualStateManager.cs * - setup accessibility expectations * - cleanup code * - cleanup * - fix up tests * - fix tests * Update AccessibilityTests.cs * - workaround remapping issue * - fix location of mappers * - fix Public API * Update PublicAPI.Unshipped.txt Co-authored-by: Rachel Kang <rachelkang@microsoft.com> * [Android] Fix crash disconnecting the IndicatorView (#11346) * Fix crash disconnecting the IndicatorView on Android * Added IndicatorViewStub Co-authored-by: Rui Marinho <me@ruimarinho.net> * Remove non platform TFM and sync up SupportedOSPlatformVersion (#11910) * Fix UpdateSemantics for UIStepper and UIPagerControl (#11937) * Make OnShouldReceiveMapTouch static (#11974) * Bump Microsoft.CodeAnalysis.NetAnalyzers (#11958) Bumps [Microsoft.CodeAnalysis.NetAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 7.0.0-preview1.22559.1 to 7.0.0. - [Release notes](https://github.com/dotnet/roslyn-analyzers/releases) - [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/main/PostReleaseActivities.md) - [Commits](https://github.com/dotnet/roslyn-analyzers/commits/7.0.0) --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.NetAnalyzers dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update Essentials MainThread API Docs (#11934) * Update Essentials MainThread API Docs * Update MainThread.netstandard.cs * Update src/Essentials/src/MainThread/MainThread.shared.cs Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> * Update Essentials Flashlight API Docs (#11920) * Prepare MAUI to support building with NuGets (#11946) * Prepare MAUI to support building with NuGets * Exclude resizetizer when UseMauiNuGets=True * Bump Xamarin.Firebase.AppIndexing from 120.0.0.9 to 120.0.0.10 (#11929) Bumps [Xamarin.Firebase.AppIndexing](https://github.com/xamarin/GooglePlayServicesComponents) from 120.0.0.9 to 120.0.0.10. - [Release notes](https://github.com/xamarin/GooglePlayServicesComponents/releases) - [Commits](https://github.com/xamarin/GooglePlayServicesComponents/commits) --- updated-dependencies: - dependency-name: Xamarin.Firebase.AppIndexing dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix crash typing in Shell SearchHandler on iOS (#11927) * Fix crash using BackButtonBehavior and navigating to root (#11438) Fixes #11401 Fixes #10514 * Fix crash using BackButtonBehavior and navigating to root * Added Device Test * - add unit test and fixup ShellToolbar to unhook from previous command * - remove extra call to OnBackButtonCommandPropertyChanged * - remove excess code from ShellToolbar Co-authored-by: Shane Neuville <shneuvil@microsoft.com> * [create-pull-request] automated change (#11949) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Vibrate - Detect zero duration and return early (#11314) * Detect zero duration and return early * Check for < 0 condition as well Co-authored-by: Jonathan Dick <jondick@gmail.com> * Fix SwipeItemView size issues on Android (#10522) Fixes #10065 Fixes #6018 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Alex Soto <alex@alexsoto.me> Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Jonathan Dick <jondick@gmail.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> Co-authored-by: TJ Lambert <tjlambert@microsoft.com> Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com> Co-authored-by: Craig Dunn <craig.dunn@microsoft.com> Co-authored-by: Jay Cho <chojoong@gmail.com> Co-authored-by: Richard Garside <code@nogginbox.co.uk> Co-authored-by: Mike Bond <mjbond-msft@outlook.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: Rachel Kang <rachelkang@microsoft.com> Co-authored-by: André Krämer <andre@andrekraemer.de> Co-authored-by: Nicholas Bauer <nicholasbauer@outlook.com> Co-authored-by: lindexi <lindexi@users.noreply.github.com> Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com> Co-authored-by: Matt Johnson-Pint <mattjohnsonpint@gmail.com> Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com>
samhouts
added
the
fixed-in-8.0.0-preview.1.7762
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
In my application I adjust flyout items dynamically. Whereas "FlyoutItem.IsVisible" accepts a BindableObject, "FlyoutItemIsVisible" does not. This seems like an oversight to me.
On a related note, changing the "FlyoutItemIsVisible" dynamically changes its order in the list. This seems like a bug to me, but it's possible that addressing the former will also address the latter.
Public API Changes
Microsoft.Maui.Controls.BaseShellItem.FlyoutItemIsVisible
Intended Use-Case
Data binding my shell to a view model.
The text was updated successfully, but these errors were encountered: