Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate syntax lists with the correct type #6596

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

sharwell
Copy link
Member

No description provided.

@sharwell sharwell requested a review from a team as a code owner April 19, 2023 21:22
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #6596 (9506efd) into main (4208547) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6596      +/-   ##
==========================================
- Coverage   96.43%   96.42%   -0.01%     
==========================================
  Files        1373     1373              
  Lines      320260   320329      +69     
  Branches    10296    10297       +1     
==========================================
+ Hits       308832   308888      +56     
- Misses       8973     8980       +7     
- Partials     2455     2461       +6     

@sharwell sharwell enabled auto-merge April 19, 2023 21:49
Copy link
Member

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a unit test?

@sharwell sharwell merged commit a3fae05 into dotnet:main Apr 20, 2023
14 checks passed
@github-actions github-actions bot added this to the vNext milestone Apr 20, 2023
@sharwell sharwell deleted the fix-types branch April 20, 2023 14:48
@sharwell
Copy link
Member Author

sharwell commented Apr 20, 2023

Is it possible to add a unit test?

No, both versions of this code produce a valid result. However, the implicit operator used in the old code was made obsolete in Roslyn 4.7, so if you try building this repository with Roslyn 4.7 (even though it's explicitly configured to not use 4.7), it'll produce a build error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants