Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cast type to conform to Roslyn API #85466

Closed
wants to merge 1 commit into from

Conversation

mthalman
Copy link
Member

@mthalman mthalman commented Apr 27, 2023

The Source-build bootstrapping stage 2 build, which uses a source-built version of the latest SDK to build the product, fails with the following error in the runtime repo:

/vmr/src/runtime/artifacts/source-build/self/src/src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/InlinedTypes.cs(56,49): error CS1503: Argument 1: cannot convert from 'Microsoft.CodeAnalysis.SeparatedSyntaxList<Microsoft.CodeAnalysis.SyntaxNode>' to 'Microsoft.CodeAnalysis.SeparatedSyntaxList<Microsoft.CodeAnalysis.CSharp.Syntax.TypeSyntax>' [/vmr/src/runtime/artifacts/source-build/self/src/src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComInterfaceGenerator.csproj]

This is a similar issue to dotnet/roslyn-analyzers#6596. This is fixed by referencing the correct type.

Related to dotnet/source-build#3425

@ghost
Copy link

ghost commented Apr 27, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

The Source-build bootstrapping stage 2 build, which uses a source-built version of the latest SDK to build the product, fails with the following error in the runtime repo:

/vmr/src/runtime/artifacts/source-build/self/src/src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/InlinedTypes.cs(56,49): error CS1503: Argument 1: cannot convert from 'Microsoft.CodeAnalysis.SeparatedSyntaxList<Microsoft.CodeAnalysis.SyntaxNode>' to 'Microsoft.CodeAnalysis.SeparatedSyntaxList<Microsoft.CodeAnalysis.CSharp.Syntax.TypeSyntax>' [/vmr/src/runtime/artifacts/source-build/self/src/src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComInterfaceGenerator.csproj]

This is a similar issue to dotnet/roslyn-analyzers#6596. This is fixed by referencing the correct type.

Author: mthalman
Assignees: mthalman
Labels:

area-System.Runtime.InteropServices

Milestone: -

Copy link
Member

@jtschuster jtschuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MichaelSimons
Copy link
Member

Gentle ping to complete this PR so that we can resolve the source-build side of this.

@jtschuster
Copy link
Member

Sorry for the delay, this file actually just got deleted from the repo, though, so we shouldn't hit the issue anymore.

@jtschuster jtschuster closed this May 16, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants