Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow projects to be loaded/added unloaded/removed during EnC/HR session #1204

Open
amcasey opened this issue Mar 11, 2015 · 1 comment
Open

Allow projects to be loaded/added unloaded/removed during EnC/HR session #1204

amcasey opened this issue Mar 11, 2015 · 1 comment
Assignees
@tmat
Labels
Area-Interactive Bug Interactive-EnC
Milestone
Backlog

Comments

@amcasey
Copy link
Member

amcasey commented Mar 11, 2015 •
edited by tmat
Loading

We currently ignore project that were not loaded when the session started.

Tracks TODOs in sources.

Prereq:
#56253
@amcasey amcasey added this to the 1.0 (stable) milestone Mar 12, 2015
@wschae wschae mentioned this issue Apr 3, 2015
Merged
wschae added a commit to wschae/roslyn that referenced this issue Apr 3, 2015
@wschae
Fix NullReferenceException during debugging
a3bf5b0 
Add a TODO with an issue number dotnet#1204
wschae added a commit that referenced this issue Apr 3, 2015
@wschae
Merge pull request #1779 from wschae/watson
eeb8a12 
Fix NullReferenceException during debugging

When opening a file during a debugging session, VS sets its buffer read-only when it is not editable. To do so, VS asks its document to the workspace but in some cases, the workspace returns nothing, causing NRE and VS Crash. In this PR, we defensively add a null check and log it to make a further investigation easier.

Noth that Issue #1204 is tracking to fix this issue directly (by enforcing the workspace to load projects before EnC).
wschae added a commit to wschae/roslyn that referenced this issue Apr 3, 2015
@wschae
Fix NullReferenceException during debugging
a377e75 
Add a TODO with an issue number dotnet#1204

(cherry picked from commit a3bf5b0)
@wschae wschae mentioned this issue Apr 3, 2015
Merged
@Pilchie Pilchie removed the Area-IDE label Apr 23, 2015
@ManishJayaswal ManishJayaswal modified the milestones: 1.1, 1.0 (stable) May 5, 2015
@tmat tmat mentioned this issue Jun 30, 2015
Merged
@ManishJayaswal ManishJayaswal assigned tmat and unassigned wschae Aug 19, 2015
@tmat tmat modified the milestones: 1.2, 1.1 Oct 8, 2015
@ManishJayaswal ManishJayaswal modified the milestones: 1.2, 1.3 Jan 27, 2016
@ManishJayaswal ManishJayaswal modified the milestones: 1.3, 2.0 (RC) May 6, 2016
@tmat tmat modified the milestones: 2.1, 2.0 (RC) Oct 5, 2016
@tmat tmat modified the milestones: 15.6, 15.1 May 22, 2017
@tmat tmat modified the milestones: 15.5, 15.later Sep 7, 2017
@jinujoseph jinujoseph modified the milestones: 15.6, Unknown Nov 3, 2017
@jinujoseph jinujoseph mentioned this issue Jun 3, 2018
Closed
43 tasks
@tmat tmat modified the milestones: Backlog, 16.3.P1 Jul 1, 2019
@jinujoseph jinujoseph modified the milestones: 16.3.P1, 16.3.P3 Aug 5, 2019
@jinujoseph jinujoseph modified the milestones: 16.3.P3, Backlog Aug 9, 2019
@tmat tmat mentioned this issue Sep 8, 2021
Open
12 tasks
@tmat tmat changed the title Force loading of workspace projects before beginning EnC session Allow projects to be loaded/added/removed during EnC/HR session Sep 8, 2021
@dotnet dotnet deleted a comment from amcasey Sep 8, 2021
@dotnet dotnet deleted a comment from wschae Sep 8, 2021
@dotnet dotnet deleted a comment from wschae Sep 8, 2021
@tmat tmat self-assigned this Sep 8, 2021
@tmat tmat changed the title Allow projects to be loaded/added/removed during EnC/HR session Allow projects to be loaded/added unloaded/removed during EnC/HR session Sep 8, 2021
@tmat tmat mentioned this issue Sep 8, 2021
Merged
@jasonmalinowski
Copy link
Member

Note this may require more work than just on the Roslyn side. As an experiment I tried this on a WinForms app while doing some testing:

  1. Start the WinForms app.
  2. Add a new class library project.
  3. Consume that class library project in the WinForms app.
  4. Resume/click hot reload.
  5. Exercise the new path in the WinForms app.

In this case, I got the WinForms unhandled exception dialog for the failure to load the assembly. So this implies to me we correctly applied the E&C edit consuming the new assembly, but since it's not deployed the application won't actually now where to load it from, since it's not anywhere it can find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmat tmat

Labels
Area-Interactive Bug Interactive-EnC
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
9 participants
@tmat @jasonmalinowski @Pilchie @gafter @wschae @ManishJayaswal @amcasey @MattGertz @jinujoseph