Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple writes to xunit.abstraction in our build #18753

Open
jaredpar opened this issue Apr 17, 2017 · 3 comments
Open

Multiple writes to xunit.abstraction in our build #18753

jaredpar opened this issue Apr 17, 2017 · 3 comments
Assignees
Labels
Area-Infrastructure Test Test failures in roslyn-CI
Milestone

Comments

@jaredpar
Copy link
Member

jaredpar commented Apr 17, 2017

This issue tracks removing the work around for double writes of xunit.abstractions.dll in our build.

This problem comes about due to a collection of packages that we reference. In order to leverage Test Explorer / LUT testing we need to have these packages referenced:

  • xunit.runner.desktop
  • xunit

Both of these include xunit.abstractions.dll in different forms: content and reference respectively. This creates a double write violation in our build and fails the correctness leg.

As a work around we use a target, RemoveDuplicateContent, to remove the DLL included via the
Content list. This issue tracks resolving the core problem with the xunit team and ideally removing this hack.

xunit/xunit#1651

@jaredpar jaredpar added this to the 15.3 milestone Apr 17, 2017
@jaredpar jaredpar self-assigned this Apr 17, 2017
@MattGertz MattGertz added the Test Test failures in roslyn-CI label May 28, 2017
@MattGertz MattGertz modified the milestones: 15.5, 15.3 Jun 30, 2017
@MattGertz
Copy link
Contributor

Mondo escrow triage: test-only, moving out.

@jaredpar
Copy link
Member Author

Fixed a while back.

@tmat tmat reopened this Jun 19, 2018
@tmat
Copy link
Member

tmat commented Jun 19, 2018

Actually, this is still a problem. The workaround is in Imports.targets and removing it adds double-writes back.

@tmat tmat modified the milestones: 15.5, Unknown Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Test Test failures in roslyn-CI
Projects
None yet
Development

No branches or pull requests

3 participants