Build and Unit test failures in 'master' branch

[OmerRaviv]

To carry on the CodePlex discussion with @MattGertz and @KevinRansom, I'm still seeing many unit test failures on the GitHub master branch. I assume you are still working on this as part of the move to GitHub but I thought it might be helpful to report the issues I'm seeing right now.

I created a clean VS2015 CTP5 machine on Azure today, installed the CTP SDK, cloned Roslyn (at the time master's HEAD was 7fed8e8) and ran msbuild /m BuildAndTest.proj /p:DeployExtension=false.

Here are the problems I saw:

Build Failure

C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\VSSDK\Microsoft.VsSDK.targets(760,5):     error : CreatePkgDef : error : FileLoadException: Could not load file or assembly 'OpenSourceDebug,    Version=42.42.42.42, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its    dependencies. Strong name validation failed. (Exception from HRESULT: 0x8013141A)   [c:\dev\roslyn\Src\Tools\Source\OpenSourceDebug\OpenSourceDebug.csproj]

I ran sn -Vr *,31bf3856ad364e35 to work around this.

Crashes during test run

When the tests run, for every test tries to launch the command line compiler (and there are many), a crash dialog pops up saying that "VBCSCompiler has stopped working" or "csc.exe has stopped working". I also got an error saying:

Unhandled Exception: System.IO.FileLoadException: Could not load file or assembly 'csc,Version=42.42.42.42, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. Strong name validation failed. (Exception from HRESULT: 0x8013141A) ---

Again, this seems to be related to strong name validations, and this time the fact I SN -Vr'ed that same public key didn't help. To get past the crash dialogs, I manually deleted Roslyn.Compilers.CompilerServer.UnitTests.dll Roslyn.Compilers.CSharp.CommandLine.UnitTests.dll and Roslyn.Compilers.VisualBasic.CommandLine.UnitTests.dll, and then ran:
msbuild /target:test /m BuildAndTest.proj /p:DeployExtension=false

Remaining unit test failures

Finally, the resulting UnitTestResults.html file reported 2 unit test failures, while the command-line window consistently reported 39.

[KevinRansom]

Hey Omer,

Per … https://github.com/dotnet/roslyn/wiki/Building-Testing-and-Debugging you should build, test and debug against the branch releases/Dev14Preview.

There is work currently underway will make master branch suitable for testing and debugging, however, currently our internal processes are so different from our open source ones that the OSS master branch will not work with the released toolsets. Our goal is to have our Dev team using the exact same processes and tools as the OSS community, but, we are not quite there yet.

I hope this helps,

Kevin
From: OmerRaviv [mailto:notifications@github.com]
Sent: Saturday, January 17, 2015 7:20 AM
To: dotnet/roslyn
Cc: Kevin Ransom
Subject: [roslyn] Build and Unit test failures in 'master' branch (#22)

To carry on the CodePlex discussionhttp://roslyn.codeplex.com/discussions/571919 with @MattGertzhttps://github.com/MattGertz and @KevinRansomhttps://github.com/KevinRansom, I'm still seeing many unit test failures on the GitHub master branch. I assume you are still working on this as part of the move to GitHub but I thought it might be helpful to report the issues I'm seeing right now.

I created a clean VS2015 CTP5 machine on Azure today, installed the CTP SDK, cloned Roslyn (at the time master's HEAD was 7fed8e87fed8e8) and ran msbuild /m BuildAndTest.proj /p:DeployExtension=false.

Here are the problems I saw:

Build Failure

C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\VSSDK\Microsoft.VsSDK.targets(760,5): error : CreatePkgDef : error : FileLoadException: Could not load file or assembly 'OpenSourceDebug, Version=42.42.42.42, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. Strong name validation failed. (Exception from HRESULT: 0x8013141A) [c:\dev\roslyn\Src\Tools\Source\OpenSourceDebug\OpenSourceDebug.csproj]

I ran sn -Vr *,31bf3856ad364e35 to work around this.

Crashes during test run

When the tests run, for every test tries to launch the command line compiler (and there are many), a crash dialog pops up saying that "VBCSCompiler has stopped working" or "csc.exe has stopped working". I also got an error saying:

Unhandled Exception: System.IO.FileLoadException: Could not load file or assembly 'csc,Version=42.42.42.42, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. Strong name validation failed. (Exception from HRESULT: 0x8013141A) ---

Again, this seems to be related to strong name validations, and this time the fact I SN -Vr'ed that same public key didn't help. To get past the crash dialogs, I manually deleted Roslyn.Compilers.CompilerServer.UnitTests.dll Roslyn.Compilers.CSharp.CommandLine.UnitTests.dll and Roslyn.Compilers.VisualBasic.CommandLine.UnitTests.dll, and then ran:
msbuild /target:test /m BuildAndTest.proj /p:DeployExtension=false

Remaining unit test failures

Finally, the resulting UnitTestResults.html filehttps://drive.google.com/file/d/0B_DL7JsBKCwiVkpjVFlTQ180ZDg/view?usp=sharing reported 2 unit test failures, while the command-line window consistently reported 39.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/22.

[OmerRaviv]

Thank you for the clarification! I actually just finished porting my two pull requests from CodePlex to GitHub as per @Pilchie's request on Twitter, made sure they do not cause any failures on top of what was already failing, and was about to send them in. I assumed it would be more convenient to the team if I send them on master. I hope that's okay?

[KevinRansom]

I expect it will be fine.

And thanks for your contributions.

Kevin

[jaredpar]

This is a problem I'm actively working on at the moment. I'm hoping to get the signing issue fixed over the weekend.

Once that's done I'm going to be hooking up a CI system to the repo to prevent this and other breaks in the future.

[codespare]

You could maybe introduce a Dev branch for bleeding edge that can break build and track it with Master but only when it builds?
git pull can make you feel like a lemming otherwise: you realize you're falling before you notice there was a cliff.

[jaredpar]

These should be fixed now.