-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master into future #11058
Merged
Merged
Merge master into future #11058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clicking automation elements.
This simplies some of the lifetime handling inside the type.
This brings along our standard trace listener that converts assert failures over to exceptions, so we don't need IntegrationTraceListener anymore.
If the VS STA thread is busy, it can reject any calls we make. This retries them explicitly. I don't like this change, but I don't have a better option that I know of.
This just hides bugs. If there's a specific point of cleanup that is flaky, we should target that specific area.
This moves the cleanup process of a test during that test, so that way any screwups are blamed on the right test.
Otherwise it reuses the default which can conflict if we start another instance.
New Visual Studio integration test framework improvements
… within a logical not expression
Integration Test Framework
Few other fixes
… transitive dependency due to perf concern.
Move Perf helpers into binary
Remove Redundant Cast should not incorrectly suggest to remove a cast within a logical not expression
change default to only re-analyze direct dependencies rather than all…
csi.exe should emit exception to stderr, not stdout
…ange Temporarily disable test CurrentWorkingDirectory_Change
This code has been moved to http://dotnet/roslyn-project-system
There are 2 changes here 1. Move some of the helpers from test_util to tools_util since the helpers are not depended on the helper binary and can work without any dependencies 2. Introduce TriggerAutomation.bat, which triggers the automation process. The reason we need a bat file to trigger this and not a csx or a new csx is because running the csx requires the helper binary. Hence we need to run the csx files from the binaries folder but we cannot have binaries in place if we dont fetch them in the first place. This is a cyclic problem that has to be broken with the help of one initial Trigger Batch file
@dotnet-bot test vsi please |
…hange Reenable CurrentWorkingDirectory_Change
Remove ProjectSystem code
Fix automation to fetch
Make completion service public
…-future20160504-150015 Conflicts: src/Compilers/Core/Portable/PublicAPI.Unshipped.txt src/Dependencies/VisualStudio/project.json src/Features/CSharp/Portable/CSharpFeatures.csproj src/Features/Core/Portable/Features.csproj src/Workspaces/Core/Portable/PublicAPI.Unshipped.txt
test vsi please |
@dotnet-bot retest prtest/lin/dbg/unit32 please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into future.
@dotnet/roslyn-infrastructure:
Once the merge can be made and all the tests pass, you are free to merge the pull request.