-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master into future #11161
Merged
Merged
Merge master into future #11161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling TestUtilities.InitUtilities from within the library, instead of a csx file, will result in the path of the file where the library was initially built to be passed to InitUtilities which is not the expected behavior. Fixing it in all occurence Also removing some unnecessary and unused helpers
Since this file wasn't being included in the VSIX, it was having no effect. We're better off using CodeBase attributes anyways which apply earlier in the assembly resolution process.
This is correctly bundled along with the language services VSIX, which is the place it should ship with. We already take a VSIX dependency upon that VSIX.
This is a DLL that doesn't ship and isn't used for anything other than pkgdef generation.
…tsetup Change contents of the TestSetup project
While installing the VSIXes using the install_vsixes.csx, uninstall the previous VSIXes before installing the new ones.
Call TestUtilities.InitUtilities appropriately
uninstall previous vsixes
@dotnet-bot test vsi please |
Check for Directory.Exists before deleting
Update CoreFX dependencies to rc3-24102-00
…-future20160507-150018
test vsi please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into future.
@dotnet/roslyn-infrastructure:
Once the merge can be made and all the tests pass, you are free to merge the pull request.