Publish NuGet packages for 15.6 #23408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is incrementing our version numbers as a part of moving to the next VS release.
|
CC @dotnet/roslyn-infrastructure |
jasonmalinowski
requested changes
Nov 27, 2017
build/config/PublishData.json
Outdated
| @@ -1,18 +1,18 @@ | |||
| { | |||
| "branches": { | |||
| "dev15.5.x": { | |||
| "master": { | |||
There was a problem hiding this comment.
This should be master-vs-deps, as that's where we'll be publishing packages.
There was a problem hiding this comment.
(or alternately: if you do want to publish out of master, then the channels needs some way to distinguish)
build/Targets/Versions.props
Outdated
| <!-- The release moniker for our packages. Developers should use "dev" and official builds pick the branch | ||
| moniker listed below --> | ||
| <RoslynNuGetMoniker Condition="'$(RoslynNuGetMoniker)' == ''">dev</RoslynNuGetMoniker> | ||
| <RoslynNuGetMoniker Condition="'$(OfficialBuild)' == 'true'">beta3</RoslynNuGetMoniker> | ||
| <RoslynNuGetMoniker Condition="'$(OfficialBuild)' == 'true'">beta1</RoslynNuGetMoniker> |
There was a problem hiding this comment.
beta2 now that this branch is Preview 2?
|
Responded to feedback |
|
cc @genlu |
shyamnamboodiripad
approved these changes
Nov 28, 2017
|
@jasonmalinowski okay now that feedback addressed? |
jasonmalinowski
approved these changes
Nov 28, 2017
genlu
reviewed
Nov 28, 2017
| "nuget": [ "https://dotnet.myget.org/F/roslyn/api/v2/package" ], | ||
| "vsix": [ "https://dotnet.myget.org/F/roslyn/vsix/upload" ], | ||
| "channels": [ "dev15.5", "dev15.5p3" ] | ||
| "channels": [ "dev15.6" ] |
There was a problem hiding this comment.
Just curious, what does the channel do?
There was a problem hiding this comment.
This updates value in the dotnet/versions repo.
genlu
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating our publishing story for the 15.6 release: