Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for nameof(typeParam) in method parameter default value #2379

Merged
merged 2 commits into from
May 1, 2015

Conversation

gafter
Copy link
Member

@gafter gafter commented Apr 29, 2015

Fixes #564

@AlekseyTs @marstr please review

@gafter gafter added Area-Compilers Test Test failures in roslyn-CI labels Apr 29, 2015
@gafter gafter self-assigned this Apr 29, 2015
@gafter gafter added this to the 1.0 (stable) milestone Apr 29, 2015
@gafter gafter added the 4 - In Review A fix for the issue is submitted for review. label Apr 29, 2015
@gafter
Copy link
Member Author

gafter commented Apr 29, 2015

@dotnet-bot test this please

<compilation>
<file name="a.vb">
Module Program
Sub M(Of TP)(Optional name As String = NameOf(TP))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding Sub Main that calls this function without arguments, printing the value within this function and verifying expected output in CompileAndVerify call.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

gafter added a commit that referenced this pull request May 1, 2015
Add a test for nameof(typeParam) in method parameter default value
@gafter gafter merged commit d8602d0 into dotnet:master May 1, 2015
@gafter gafter removed the 4 - In Review A fix for the issue is submitted for review. label May 1, 2015
@gafter gafter removed their assignment May 1, 2015
@gafter gafter deleted the fix564 branch November 5, 2015 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a test that a method type parameter can be used in Nameof() in parameter default value in VB
3 participants