Merge dev16.0.x to dev16.0.x-vs-deps #30292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of IThreadingContext to this type's constructor broke TypeScript, which they already have a build for that deals with the change. However it requires a simultaneous insertion which is proving difficult to achieve. Adding this overload (which is admittedly a total hack) allows TypeScript to continue functioning even with Roslyn's change.
Add a overload to AsynchronousViewTaggerProvider for TypeScript
|
|
|
retest ubuntu_16_debug_prtest please |
|
Tracked by #30293 |
|
retest ubuntu_16_debug_prtest please |
xoofx
pushed a commit
to stark-lang/stark-roslyn
that referenced
this pull request
Apr 16, 2019
….0.x-vs-deps Merge dev16.0.x to dev16.0.x-vs-deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from dev16.0.x into dev16.0.x-vs-deps.
git fetch --all git checkout merges/dev16.0.x-to-dev16.0.x-vs-deps git reset --hard upstream/dev16.0.x-vs-deps git merge upstream/dev16.0.x # Fix merge conflicts git commit git push merges/dev16.0.x-to-dev16.0.x-vs-deps --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.