Merge master to master-vs-deps #33206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new "Preview" language version for C# that means the latest supported language version + the preview features available in the compiler. Also changes the "Default" (unspecified) language version to mean Preview, but provides a warning when preview features are used.
…Info_Metadata.cs Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
…Info_Metadata.cs Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
…Info_Metadata.cs Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
Resaon for the change should be clear in the diff
Avoid a lambda allocation when accessing a cache in a hotpath.
Re-enable mono CI build
Make IPropertySubpattern Internal
* removed 3 OptProf tests that kept failing opened tracking issue - #33180 this should let us have green OptProf training runs. * Removed all DDRIT.RPS.CSharp tests for now
Merge dev16.0-preview3 to master
This reverts commit d11147e.
|
@RikkiGibson Check roslyn-integration-CI failed and there are conflicting files. Please have a look. |
* Disable nullable analysis for generated files - Record if a syntax tree is generated - Return the default nullable state of a generated syntax tree as disabled - Disable nullable warnings at the beginning of a generated syntax tree
Handle opening/closing of additional files in VS Workspace open file …
|
Windows_Desktop_Spanish_Unit_Tests Job is showing test failures: FYI @dotnet/roslyn-infrastructure @ivanbasov |
|
@JoeRobich pointed out that #30795 seems related. However it looks like features/recursive-patterns merged all the way back in January in #25912. @333fred any chance commit d2523e5 is related? |
RikkiGibson
approved these changes
Feb 8, 2019
|
Have seen the Determinism build hang and fail a few times today. All the other legs looked good so I am going to override and merge this to get the snap going. |
JoeRobich
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into master-vs-deps.
git fetch --all git checkout merges/master-to-master-vs-deps git reset --hard upstream/master-vs-deps git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-master-vs-deps --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.