-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merges/master to features/lsp support #35407
Merged
heejaechang
merged 809 commits into
features/lspSupport
from
merges/master-to-features/lspSupport
May 2, 2019
Merged
Merges/master to features/lsp support #35407
heejaechang
merged 809 commits into
features/lspSupport
from
merges/master-to-features/lspSupport
May 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revoke IVTs to dotnet/roslyn-analyzers
Roslyn.Compilers.CompilerServer.UnitTests removed in 2472120 Roslyn.Test.Utilities.CoreClr removed in cf58bbc Roslyn.Test.Utilities.Desktop removed in cf58bbc Roslyn.Compilers.CSharp.PerformanceTests removed in cd33333 Roslyn.Test.Utilities.FX45 removed in b77c547 Roslyn.Compilers.VisualBasic.PerformanceTests never existed (typo from 3c14b04) Roslyn.Compilers.CSharp.Test.Utilities.Desktop removed in edd89e4
Roslyn.Compilers.VisualBasic.Test.Utilities.Desktop incorrectly added in a70cdce VBCSCompilerPortable removed in b2bd77b Microsoft.CodeAnalysis.CompilerServer removed in b00224e Roslyn.VisualStudio.Test.Utilities.Next renamed in e0e16d7 Microsoft.CodeAnalysis.Scripting.Destkop.UnitTests never existed (typo) Roslyn.DebuggerVisualizers removed in d7e4939 Microsoft.VisualStudio.LanguageServices.VisualBasic.UnitTests never existed (typo in 7ab3b77) Roslyn.Services.Editor.CSharp.UnitTests2 renamed in bb1f97b
Update foreach based on nullable analysis
* changed the way we report live analysis to task center previously, we listen to diagnostic service to report progress. problem is that, it only raise event if it found errors on a file. so what we report is actually last file we found errors on rather than file that we are analyzing. this caused confusion since we report in task center that we are analyzing file "A" when it is actually "analyzed" not "analyzing" another issue is since it only report file that contains errors. we might not actually show anything in task center if there is no error, or show file "A" for long time if that is only file with errors. this PR changes the experience closer to what users would expects. and now progress is for solution crawler not specifically on diagnostics. now we report file that solution crawler is analyzing. there is still cavet such as solution cralwer can pause between processing a file if VS is busy. but it will still show file "A". or we will not update UI at least 200ms a part and etc. since it is task center where we don't want to be too impactful to VS, based on feeedback we will see whether we need to do more such as detect solution crawlwer pause and update task center to show pasue. or update task center to show different stage such as analyzing/analyzed. or show in task center, what analyzer is actually running such as diagnostic, todo, designer attribute scan, find all reference cache and etc. * addressing PR feedbacks
Update Async Streams proposal link
…er-190429 Remove unnecessary parameter
* Additional Nullability checks for deconstruction: - Check 'this' param for extension deconstruct - Re-infer the argument types for generic extension deconstruct - Update the deconstruction method in instance cases - Update return type with visited arguments - Update tests
Fix broken links in Language Feature Status
Fixes #29956 Also introduce a helper `TypeSymbol.IsVoidType()`
This change is required in order to enable running on non-desktop TFM tests from VS test explorer window.
Merge dev16.1 to master
* Update dependencies from https://github.com/dotnet/arcade build 20190407.1 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19207.1 * Update dependencies from https://github.com/dotnet/arcade build 20190409.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19209.2 * Update dependencies from https://github.com/dotnet/arcade build 20190410.7 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19210.7 * Update dependencies from https://github.com/dotnet/arcade build 20190411.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19211.2 * Update dependencies from https://github.com/dotnet/arcade build 20190412.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19212.2 * Update dependencies from https://github.com/dotnet/arcade build 20190413.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19213.2 * Update dependencies from https://github.com/dotnet/arcade build 20190414.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19214.2 * Update dependencies from https://github.com/dotnet/arcade build 20190415.12 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19215.12 * Update dependencies from https://github.com/dotnet/arcade build 20190417.1 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19217.1 * Update dependencies from https://github.com/dotnet/arcade build 20190418.1 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19218.1 * Update dependencies from https://github.com/dotnet/arcade build 20190418.4 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19218.4 * Update dependencies from https://github.com/dotnet/arcade build 20190418.7 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19218.7 * Update dependencies from https://github.com/dotnet/arcade build 20190422.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19222.2 * Update dependencies from https://github.com/dotnet/arcade build 20190423.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19223.2 * Use Arcade CoreXT package support * Update dependencies from https://github.com/dotnet/arcade build 20190424.9 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19224.9 * Fix signing * Update dependencies from https://github.com/dotnet/arcade build 20190425.5 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19225.5 * Update dependencies from https://github.com/dotnet/arcade build 20190426.3 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19226.3 * Update dependencies from https://github.com/dotnet/arcade build 20190429.8 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19229.8 * Update dependencies from https://github.com/dotnet/arcade build 20190430.6 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19230.6
dotnet-bot
force-pushed
the
merges/master-to-features/lspSupport
branch
from
May 2, 2019 00:00
e00901f
to
7517f5d
Compare
heejaechang
force-pushed
the
merges/master-to-features/lspSupport
branch
from
May 2, 2019 08:05
7517f5d
to
e00901f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
automatic bot didn't work due to conflicts. doing manual FI.