Make the ':severity' suffix in editorconfig code style value optional #48580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes towards dotnet#44201 - All code style option editorconfig entries can now be specified as `option_name = option_value` without `:severity` suffix - `Configure code style option` code fix will no longer add add `:severity` suffix for new entries. For fix that changes existing entries which have `:severity` suffix, it will retain the existing severity suffix. Note that `Configure severity` code fix was already switched to use `dotnet_diagnostic.RuleID.severity` entries for code style diagnostics in dotnet#47052. Once we have the editorconfig UX to change code style option value and severity, we can safely deprecate the `:severity` suffix in option value syntax. All our UI gestures will use the `option_name = option_value` syntax for code style value changes and `dotnet_diagnostic.RuleID.severity = severity` syntax for severity changes and users do not need to deal with these manually editing or understanind these different syntaxes or mapping rule IDs to option names and vice versa for code styles.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
mavasani
commented
Oct 14, 2020
| @@ -98,7 +98,7 @@ public Customer() | |||
| <AnalyzerConfigDocument FilePath=""z:\\.editorconfig"">[*.{cs,vb}] | |||
|
|
|||
| # IDE0017: Simplify object initialization | |||
| dotnet_style_object_initializer = true:suggestion | |||
| dotnet_style_object_initializer = true | |||
There was a problem hiding this comment.
This is the core user facing change.
|
Ping for reviews... |
|
@mavasani I plan on taking a look at this later today. |
allisonchou
approved these changes
Oct 15, 2020
|
Thank you for the review @allisonchou! I'll wait for one more day to see if there is any further feedback. |
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes towards #44201
option_name = option_valuewithout:severitysuffixConfigure code style optioncode fix will no longer add add:severitysuffix for new entries. For fix that changes existing entries which have:severitysuffix, it will retain the existing severity suffix. Note thatConfigure severitycode fix was already switched to usedotnet_diagnostic.RuleID.severityentries for code style diagnostics in Update configure severity code fix for IDE code style diagnostics to use dotnet_diagnostic entries #47052.Once we have the editorconfig UX to change code style option value and severity, we can safely deprecate the
:severitysuffix in option value syntax. All our UI gestures will use theoption_name = option_valuesyntax for code style value changes anddotnet_diagnostic.RuleID.severity = severitysyntax for severity changes. Users would no longer need to deal with manually editing or understanding these different syntaxes or mapping rule IDs to option names and vice versa for code styles.