Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block typeof(delegate*<void>) in attributes #50903

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

333fred
Copy link
Member

@333fred 333fred commented Jan 29, 2021

We don't know how to serialize these types today, and the compiler crashes during emit. Rather than crashing, make this an explicit error until we work with the runtime team to enable the scenario. #48765 tracks this work.

We don't know how to serialize these types today, and the compiler crashes during emit. Rather than crashing, make this an explicit error until we work with the runtime team to enable the scenario. dotnet#48765 tracks this work.
@333fred 333fred requested a review from a team as a code owner January 29, 2021 22:06
@333fred 333fred added the Feature - Function Pointers Adding Function Pointers label Jan 29, 2021
@333fred
Copy link
Member Author

333fred commented Jan 29, 2021

@dotnet/roslyn-compiler for a (hopefully) quick review.

@jcouv jcouv self-assigned this Jan 30, 2021
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@333fred 333fred changed the base branch from release/dev16.9 to master January 30, 2021 01:33
@runfoapp runfoapp bot mentioned this pull request Feb 1, 2021
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@333fred 333fred merged commit 6c8cc9d into dotnet:master Feb 1, 2021
@333fred 333fred deleted the release/dev16.9 branch February 1, 2021 18:02
@ghost ghost added this to the Next milestone Feb 1, 2021
@RikkiGibson RikkiGibson modified the milestones: Next, 16.10.P1 Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants