-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ISymbol.MetadataToken #55913
Add ISymbol.MetadataToken #55913
Conversation
@@ -103,6 +103,8 @@ ImmutableArray<SymbolDisplayPart> ISymbol.ToMinimalDisplayParts(SemanticModel se | |||
|
|||
string ISymbol.MetadataName => _name; | |||
|
|||
int ISymbol.MetadataToken => 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are non-PE symbols covered in tests? #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There aren't explicit asserts that the value is 0, no. Will add some.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a simple test. Not sure if there was anywhere else specifically these checks should be added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with review pass (iteration 5).
src/Compilers/VisualBasic/Portable/Symbols/Metadata/PE/PEMethodSymbol.vb
Outdated
Show resolved
Hide resolved
src/Compilers/VisualBasic/Portable/Symbols/Metadata/PE/PEMethodSymbol.vb
Outdated
Show resolved
Hide resolved
src/Compilers/VisualBasic/Portable/Symbols/Metadata/PE/PEMethodSymbol.vb
Outdated
Show resolved
Hide resolved
Ping @dotnet/roslyn-compiler / @jcouv for second review |
Ping @jcouv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 9)
Fixes #53486
Needed for #55834