Port 'Top Level Statements' code style PR to 17.3 #60426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
…into programMain
…MainDiagnosticAnalyzer.cs Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
…sform_ProgramMain.cs Co-authored-by: David Wengier <david.wengier@microsoft.com>
|
Already signed off in: #60383 |
CyrusNajmabadi
commented
Mar 28, 2022
| @@ -171,7 +171,10 @@ internal static class IDEDiagnosticIds | |||
|
|
|||
| public const string RemoveUnnecessaryLambdaExpressionDiagnosticId = "IDE0200"; | |||
|
|
|||
| public const string ForEachCastDiagnosticId = "IDE0210"; | |||
There was a problem hiding this comment.
intentionally taking this ID. if we back port this dev17.2, we want to keep these IDEs the same there.
CyrusNajmabadi
commented
Mar 28, 2022
| @@ -396,30 +396,21 @@ public void CSharp_VerifyIDEDiagnosticSeveritiesAreConfigurable() | |||
| # IDE0090 | |||
| dotnet_diagnostic.IDE0090.severity = %value% | |||
|
|
|||
| # IDE0110 | |||
| dotnet_diagnostic.IDE0110.severity = %value% | |||
|
|
|||
There was a problem hiding this comment.
sorting, how does it work?
davidwengier
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a user facing option in VS to control preferences around top-level-statements. Looks like:
or
When set to prefer 'Program.Main' style, if a new project is created using a template that uses top-level-statements, then we will convert that template to use the traditional style like so:
This preference is also exposed through our standard analyzer/fixer/refactoring system so it can be used to change code after a project has already been created. For example an existing Program.Main program can be converted to a top-level-statement program (if viable):
Likewise, all top-level-statement programs can be converted back to a traditional Program.Main program: