Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port 'Top Level Statements' code style PR to 17.3 #60426

Merged
merged 72 commits into from
Mar 29, 2022

Commits on Mar 25, 2022

  1. Configuration menu
    Copy the full SHA
    d9825ad View commit details
    Browse the repository at this point in the history
  2. Extract out helper

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    6819187 View commit details
    Browse the repository at this point in the history
  3. Add tests

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    0d141dd View commit details
    Browse the repository at this point in the history
  4. Add tsts

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    f671beb View commit details
    Browse the repository at this point in the history
  5. Update src/Analyzers/CSharp/Analyzers/CSharpAnalyzers.projitems

    Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
    CyrusNajmabadi and Youssef1313 authored Mar 25, 2022
    Configuration menu
    Copy the full SHA
    6ecd6f1 View commit details
    Browse the repository at this point in the history
  6. Simplify

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    18b531a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7039b08 View commit details
    Browse the repository at this point in the history
  8. Update src/Analyzers/CSharp/Analyzers/ConvertProgram/ConvertToProgram…

    …MainDiagnosticAnalyzer.cs
    
    Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
    CyrusNajmabadi and Youssef1313 authored Mar 25, 2022
    Configuration menu
    Copy the full SHA
    4eef1a0 View commit details
    Browse the repository at this point in the history
  9. Fix suppression logic

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    b5df649 View commit details
    Browse the repository at this point in the history
  10. Fix suppression logic

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    3d15c8c View commit details
    Browse the repository at this point in the history
  11. Add refactoring tests

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    e04bbf0 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c251ca8 View commit details
    Browse the repository at this point in the history
  13. Add using

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    f9dfa65 View commit details
    Browse the repository at this point in the history
  14. Simplify

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    8232b92 View commit details
    Browse the repository at this point in the history
  15. Fix suppression

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    f4b6b09 View commit details
    Browse the repository at this point in the history
  16. Add ui

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    b6d5441 View commit details
    Browse the repository at this point in the history
  17. Add automation object

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    deafa3b View commit details
    Browse the repository at this point in the history
  18. Fixup tests

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    8663fa7 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    3ea54d0 View commit details
    Browse the repository at this point in the history
  20. Increase checks

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    ea934e9 View commit details
    Browse the repository at this point in the history
  21. Add fixer

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    67a81a2 View commit details
    Browse the repository at this point in the history
  22. tests

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    d6fbcfc View commit details
    Browse the repository at this point in the history
  23. tests

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    f529beb View commit details
    Browse the repository at this point in the history
  24. tests

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    c7feef0 View commit details
    Browse the repository at this point in the history
  25. tests

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    b12b4ae View commit details
    Browse the repository at this point in the history
  26. tests

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    45c7780 View commit details
    Browse the repository at this point in the history
  27. Fixup

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    a7d6369 View commit details
    Browse the repository at this point in the history
  28. More tests

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    f6d9923 View commit details
    Browse the repository at this point in the history
  29. Extract helpers

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    c729d25 View commit details
    Browse the repository at this point in the history
  30. In progress

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    de1fe3f View commit details
    Browse the repository at this point in the history
  31. Finish refactoring

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    9f9066a View commit details
    Browse the repository at this point in the history
  32. Fixup downstream

    CyrusNajmabadi committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    7853415 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2022

  1. Configuration menu
    Copy the full SHA
    76773fb View commit details
    Browse the repository at this point in the history
  2. cleanup

    CyrusNajmabadi committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    bf742db View commit details
    Browse the repository at this point in the history
  3. Flip

    CyrusNajmabadi committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    489f0bb View commit details
    Browse the repository at this point in the history
  4. Update tests

    CyrusNajmabadi committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    b78c8ff View commit details
    Browse the repository at this point in the history
  5. Break apart

    CyrusNajmabadi committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    b408e4f View commit details
    Browse the repository at this point in the history
  6. Simplify

    CyrusNajmabadi committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    882b1bd View commit details
    Browse the repository at this point in the history
  7. Add comments

    CyrusNajmabadi committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    0714d3c View commit details
    Browse the repository at this point in the history
  8. add comment

    CyrusNajmabadi committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    15cbb00 View commit details
    Browse the repository at this point in the history
  9. Update tests

    CyrusNajmabadi committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    49795f6 View commit details
    Browse the repository at this point in the history
  10. Update comment

    CyrusNajmabadi committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    6da5e10 View commit details
    Browse the repository at this point in the history
  11. fix export name

    CyrusNajmabadi committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    b9abe2a View commit details
    Browse the repository at this point in the history
  12. fix test

    CyrusNajmabadi committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    f2baac2 View commit details
    Browse the repository at this point in the history
  13. fix test

    CyrusNajmabadi committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    66059ad View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    5f352c7 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2022

  1. Update src/Analyzers/CSharp/Analyzers/ConvertProgram/ConvertProgramAn…

    …alysis_ProgramMain.cs
    
    Co-authored-by: David Wengier <david.wengier@microsoft.com>
    CyrusNajmabadi and davidwengier authored Mar 27, 2022
    Configuration menu
    Copy the full SHA
    3c96d55 View commit details
    Browse the repository at this point in the history
  2. Update src/Analyzers/CSharp/Analyzers/ConvertProgram/ConvertProgramAn…

    …alysis_TopLevelStatements.cs
    
    Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
    CyrusNajmabadi and Youssef1313 authored Mar 27, 2022
    Configuration menu
    Copy the full SHA
    cc5b6a2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b8f5617 View commit details
    Browse the repository at this point in the history
  4. Allow unsafe

    CyrusNajmabadi committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    40a8994 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    42176bb View commit details
    Browse the repository at this point in the history
  6. Add tests

    CyrusNajmabadi committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    d4da759 View commit details
    Browse the repository at this point in the history
  7. Add comment

    CyrusNajmabadi committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    8b9e759 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. Simplify

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    e962abc View commit details
    Browse the repository at this point in the history
  2. Update src/Features/CSharp/Portable/ConvertProgram/ConvertProgramTran…

    …sform_ProgramMain.cs
    
    Co-authored-by: David Wengier <david.wengier@microsoft.com>
    CyrusNajmabadi and davidwengier authored Mar 28, 2022
    Configuration menu
    Copy the full SHA
    4a0af65 View commit details
    Browse the repository at this point in the history
  3. Move comment

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    595cb93 View commit details
    Browse the repository at this point in the history
  4. Emit fields first

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    eca1406 View commit details
    Browse the repository at this point in the history
  5. Initialize locals

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    80a9b66 View commit details
    Browse the repository at this point in the history
  6. Simplify

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    b350fb5 View commit details
    Browse the repository at this point in the history
  7. Update comment

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    8ab0abe View commit details
    Browse the repository at this point in the history
  8. Simplufy

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    1c443e8 View commit details
    Browse the repository at this point in the history
  9. Add extension

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    1727760 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    806ebea View commit details
    Browse the repository at this point in the history
  11. abnners

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    1b4421b View commit details
    Browse the repository at this point in the history
  12. Simplify

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    8f208be View commit details
    Browse the repository at this point in the history
  13. Add header tests

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    42712c6 View commit details
    Browse the repository at this point in the history
  14. fix

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    62229fe View commit details
    Browse the repository at this point in the history
  15. revert

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    c284334 View commit details
    Browse the repository at this point in the history
  16. Simplify logic

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    2ac8424 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    0de15bb View commit details
    Browse the repository at this point in the history
  18. Fix test

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    a3111ac View commit details
    Browse the repository at this point in the history
  19. Fix test

    CyrusNajmabadi committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    bec1b6f View commit details
    Browse the repository at this point in the history