Update MSBuild ref dependency #71069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
jasonmalinowski
approved these changes
Dec 4, 2023
| @@ -32,7 +32,7 @@ | |||
| <MicrosoftVisualStudioLanguageServerProtocolPackagesVersion>17.8.9-preview</MicrosoftVisualStudioLanguageServerProtocolPackagesVersion> | |||
| <MicrosoftVisualStudioShellPackagesVersion>17.8.36711</MicrosoftVisualStudioShellPackagesVersion> | |||
| <!-- The version of MSBuild that we reference for things depending on MSBuildWorkspace --> | |||
| <RefOnlyMicrosoftBuildPackagesVersion>16.10.0</RefOnlyMicrosoftBuildPackagesVersion> | |||
| <RefOnlyMicrosoftBuildPackagesVersion>17.3.2</RefOnlyMicrosoftBuildPackagesVersion> | |||
There was a problem hiding this comment.
We may want to just get rid of this in favor of using the other variable below, but might be good to do this one step at a time.
There was a problem hiding this comment.
Yes, I think we should align onto a single version. Roslyn currently uses 17.5.0 which isn't in SBRP, so we would need to add it there.
|
I'll hold off on merging this until we can resolve the test issue at dotnet/installer#17875 (comment) in case that requires further changes related to the version. |
ghost
added this to the 
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the ref-only dependency version for MSBuild. This helps to resolve the issue identified in dotnet/installer#17875 (comment) where the previous dependency on MSBuild 16.10.0 is causing an issue in the source build of the format repo due to NETStandard1.x dependency. This version matches the version used by the format repo.