Bind to the background of border #72682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #72681
Reason:
Context: CrispImage relies on
imageutils:ImageThemingUtilities.ImageBackgroundColorto get the correct color. (real value is used in a value converter in Image library)here is the problem, we do it wrong at the beginning:
It binds to the background of the parent element, which is not set (so transparent). So the icon would alwasys be black, and we get the problem when in dark mode. So it is tried to be fixed in this PR #72538
However, in that PR it simply removes the binding, which leads to another problem.
imageutils:ImageThemingUtilities.ImageBackgroundColorof the button would be binded to the parent. This causes problem in the blue mode, because the parentimageutils:ImageThemingUtilities.ImageBackgroundColoris set toin blue mode, causing the image changed to a light color
causing this problem
So the ultimate solution is: bind it to the background color of the rename flyout.
After:
