Follow up on addition of InternalSpecialType
#72704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekseyTs
added
Concept-API
dotnet-issue-labeler
bot
added
the
untriaged
333fred
approved these changes
Mar 25, 2024
|
@jcouv, @dotnet/roslyn-compiler For the second review |
jcouv
reviewed
Mar 25, 2024
| @@ -645,6 +645,8 @@ private static bool TryGetSpecialTypeMethod(SyntaxNode syntax, SpecialMember spe | |||
|
|
|||
| public override BoundNode VisitTypeOfOperator(BoundTypeOfOperator node) | |||
| { | |||
| Debug.Assert(node.Type.ExtendedSpecialType == InternalSpecialType.System_Type || | |||
There was a problem hiding this comment.
I didn't follow. How do we get to this case (using
InternalSpecialType.System_Typein typeof)?
This is a very common case of System.Type defined in mscorlib. The type of typeof is System.Type.
There was a problem hiding this comment.
Resolved offline, what I was missing was that you can get a type marked as SpecialType = InternalSpecialType.System_Type even though we don't have any special-type lookups in the code for it. We use well-known type lookup and generally happen to find the type from corlib, which will be marked as special type.
Thanks for clarification @AlekseyTs
jcouv
reviewed
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #72646.