Report error creating delegate from partial generic method without implementation #73060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
AlekseyTs
reviewed
Apr 17, 2024
| @@ -2788,7 +2788,7 @@ static ErrorCode getRefMismatchErrorCode(TypeKind type) | |||
| return true; | |||
| } | |||
|
|
|||
| var sourceMethod = selectedMethod as SourceOrdinaryMethodSymbol; | |||
| var sourceMethod = selectedMethod.OriginalDefinition as SourceOrdinaryMethodSymbol; | |||
| if (sourceMethod is object && sourceMethod.IsPartialWithoutImplementation) | |||
There was a problem hiding this comment.
There was only one other use of IsPartialWithoutImplementation, in CallsAreOmitted().
|
Consider adding similar tests for VB #Resolved |
Thanks, the same issue existed in VB. In reply to: 2061785068 |
RikkiGibson
reviewed
Apr 17, 2024
| { | ||
| static void Main() | ||
| { | ||
| M1(M2<int>); |
There was a problem hiding this comment.
Is there also a bug when using a method group like GenericType<int>.PartialMethod? #Resolved
There was a problem hiding this comment.
Yes, tested in _03. For that case, previously, the assembly was emitted without errors but the IL contained a reference to a missing method.
cston
changed the title
RikkiGibson
approved these changes
Apr 17, 2024
This was referenced Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72431.