Emit extension marker method as public #73994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
untriaged
jjonescz
approved these changes
Jun 17, 2024
AlekseyTs
reviewed
Jun 18, 2024
| if (constructorHandle.Kind == HandleKind.MemberReference) | ||
| { | ||
| var typeRef = metadataReader.GetMemberReference((MemberReferenceHandle)constructorHandle).Parent; | ||
| return metadataReader.GetTypeReference((TypeReferenceHandle)typeRef).Name; |
There was a problem hiding this comment.
Strictly speaking this cast isn't always valid, I think. From spec for MemberRef metadata table: "Class (an index into the MethodDef, ModuleRef,TypeDef, TypeRef, or TypeSpec
tables; more precisely, a MemberRefParent (§II.24.2.6) coded index)." I am not going to block on this because the change is for a test helper, it is an improvement and it is sufficient for the test scenarios we currently have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we need the marker to roundtrip through reference assemblies, it should not be
private.Since the name is already unspeakable, I chose
publicaccessibility.Added a PROTOTYPE marker to record that the synthesized method is still not properly emitted in reference assemblies.
Corresponding spec update: dotnet/csharplang#8121
Relates to test plan #66722