Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Run downlevel tests only on main #109919

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

maraf
Copy link
Member

@maraf maraf commented Nov 18, 2024

Based on #103118. Apparently the one test slipped through, but it should have the same limitation to run only latest TFM test on non-main branches.

Fixes #109653
Fixes #109627

Forwardport of #109723

@maraf maraf added arch-wasm WebAssembly architecture area-Infrastructure-mono os-browser Browser variant of arch-wasm labels Nov 18, 2024
@maraf maraf added this to the 10.0.0 milestone Nov 18, 2024
@maraf maraf self-assigned this Nov 18, 2024
@maraf maraf requested a review from ilonatommy as a code owner November 18, 2024 13:10
@maraf
Copy link
Member Author

maraf commented Nov 20, 2024

Starting:    Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
    Wasi.Build.Tests.WasiTemplateTests.ConsoleBuildAndRunAOT(config: "Debug", singleFileBundle: False) [STARTING]
    Wasi.Build.Tests.SdkMissingTests.SimpleBuildDoesNotFail(config: "Debug") [STARTING]
    Wasi.Build.Tests.SdkMissingTests.SimpleBuildDoesNotFail(config: "Debug") [FAIL]
      System.IndexOutOfRangeException : Index was outside the bounds of the array.
      Stack Trace:
           at System.Collections.Generic.Dictionary`2.CopyEntries(Entry[] entries, Int32 count)
           at System.Collections.Generic.Dictionary`2.AddRange(IEnumerable`1 enumerable)
        /_/src/mono/wasi/Wasi.Build.Tests/BuildTestBase.cs(255,0): at Wasm.Build.Tests.BuildTestBase.BuildProject(BuildArgs buildArgs, String id, BuildProjectOptions options)
        /_/src/mono/wasi/Wasi.Build.Tests/SdkMissingTests.cs(70,0): at Wasi.Build.Tests.SdkMissingTests.BuildWithInvalidSdkPath(String config, String extraProperties, Boolean publish, Boolean expectSuccess)
        /_/src/mono/wasi/Wasi.Build.Tests/SdkMissingTests.cs(58,0): at Wasi.Build.Tests.SdkMissingTests.SimpleBuildDoesNotFail(String config)
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
           at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)

Unrelated and weird. Trying re-run if it was some race condition

@lewing lewing merged commit b85f9f6 into dotnet:main Nov 20, 2024
24 checks passed
@maraf maraf deleted the WasmDownLevelTestsMain branch November 20, 2024 20:39
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono os-browser Browser variant of arch-wasm
Projects
None yet
2 participants