Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-staging] Fix transformer handling of boolean schemas in JsonSchemaExporter. #109975

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 19, 2024

Backport of #109954 to release/9.0-staging

/cc @eiriktsarpalis

Customer Impact

  • Customer reported
  • Found internally

Reported by an external customer in #109868. Fixes a bug in JsonSchemaExporter that occurs when users apply schema transformers on types with custom converters. It has the potential to produce incorrect schemas under certain circumstances.

Regression

  • Yes
  • No

Testing

Added unit testing for the impacted scenario.

Risk

Low. Makes a small and targeted change to product code.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @artl93

@jeffhandley jeffhandley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 26, 2024
@jeffhandley
Copy link
Member

/ba-g Errors are known and unrelated

@jeffhandley jeffhandley merged commit 718c531 into release/9.0-staging Nov 26, 2024
81 of 90 checks passed
@jeffhandley jeffhandley deleted the backport/pr-109954-to-release/9.0-staging branch November 26, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Text.Json Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants