…net/standard (#42115)

* Update dependencies from https://github.com/dotnet/core-setup build 20191024.4

- Microsoft.NETCore.App - 5.0.0-alpha1.19524.4
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha1.19524.4
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha1.19524.4

* Update dependencies from https://github.com/dotnet/corefx build 20191024.14

- runtime.native.System.IO.Ports - 5.0.0-alpha.1.19524.14
- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.14

* Update dependencies from https://github.com/dotnet/standard build 20191024.1

- NETStandard.Library - 2.2.0-prerelease.19524.1

* Nullable annotation for System.Linq.Parallel

* Use half-fences for volatile load/stores on Windows ARM64

* Updated Volatile.h in gc/env as well.
unified on type names and warning suppression.

When the source/destination address was local, genCodeForCpBlkUnroll was folding the local offset into the address mode of the generated load/store instructions as if the local address was contained. But lowering didn't actually contain the address so useless ADD instructions were still being generated.

* Remove ILLinkTrim.xml from System.Text.Json

Instead use PreserveDependencyAttribute.

* Address PR feedback

* Update dependencies from https://github.com/dotnet/coreclr build 20191024.2

- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19524.2

* Update dependencies from https://github.com/dotnet/coreclr build 20191025.1

- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19525.1

* Add support to produce WebAssembly runtime assets

* Add support to build in OSX and address PR feedback

* Change AND -> and in Directory.Build.props change region

* PR Feedback: run build in rolling CI builds as well

* Add TODO comment for WebAssembly OSGroup

* Nullable annotation for System.IO.Compression

* Revert "Nullable annotation for System.IO.Compression"

* Annotate System.Reflection.DispatchProxy for nullable

* Applying feedback

* Applying feedback

* Banging some null assertions causing error on CI

* Banging some more to clean CI build

This caught my attention because I was messing with `IsBlittableType`.

The condition `type.BaseType.IsValueType` is never true because one can never have a type whose base type is a valuetype.

I was trying to find out where this code is coming from so I can fix it only to realize it was silently deleted in #23015.

…025.2 (#8668)

- System.Windows.Extensions - 5.0.0-alpha.1.19525.2
- System.CodeDom - 5.0.0-alpha.1.19525.2
- System.Configuration.ConfigurationManager - 5.0.0-alpha.1.19525.2
- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.2
- Microsoft.NETCore.Targets - 5.0.0-alpha.1.19525.2
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.2
- Microsoft.Win32.Registry - 5.0.0-alpha.1.19525.2
- Microsoft.Win32.SystemEvents - 5.0.0-alpha.1.19525.2
- Microsoft.Windows.Compatibility - 5.0.0-alpha.1.19525.2
- System.Diagnostics.EventLog - 5.0.0-alpha.1.19525.2
- System.Security.AccessControl - 5.0.0-alpha.1.19525.2
- System.Security.Cryptography.Cng - 5.0.0-alpha.1.19525.2
- System.Security.Cryptography.Pkcs - 5.0.0-alpha.1.19525.2
- System.Security.Cryptography.ProtectedData - 5.0.0-alpha.1.19525.2
- System.Security.Cryptography.Xml - 5.0.0-alpha.1.19525.2
- System.Security.Permissions - 5.0.0-alpha.1.19525.2
- System.Security.Principal.Windows - 5.0.0-alpha.1.19525.2
- System.Text.Encodings.Web - 5.0.0-alpha.1.19525.2
- System.Text.Json - 5.0.0-alpha.1.19525.2
- System.Threading.AccessControl - 5.0.0-alpha.1.19525.2
- System.Resources.Extensions - 5.0.0-alpha.1.19525.2
- System.DirectoryServices - 5.0.0-alpha.1.19525.2
- System.Drawing.Common - 5.0.0-alpha.1.19525.2
- System.IO.FileSystem.AccessControl - 5.0.0-alpha.1.19525.2
- System.IO.Packaging - 5.0.0-alpha.1.19525.2

…42127)

This reverts commit c57cba7.

Fix getting readonly column metadata

* Get the product build to use the global package cache only.

* Move external.csproj out to the tests folder. Fix restore location so external.csproj correctly resolves its nuget-generated props/targets files.

* Fix typo.

* Fix expected failure case on platforms that don't support PGO/IBC.

* Don't error out if optimization data is not supported for the current platform.

* Fix casing that was causing the Linux x64 build to fail to find the pgo/ibc packages.

* Fix condition.

* Pass OS-Arch-Config to external test package restore.

* The platform-specific version of Microsoft.NETCore.CoreDisTools is an older version for non-Windows, so hardcode that version in stress_dependencies.csproj

* Packaging for crossgen2 as a framework dependent application.

This requires us to manually emit a runtimeconfig json for now, since the build produces a self-contained version of crossgen2.

Also includes some minor cleanups to the way we build crossgen2:
- Removed from build.proj since we explicitly build it as a self-contained application from build.cmd/build.sh
- Removed the output path property from the csproj files. We use an explicit -o argument when publishing to specify the output folder

…025.3 (#8671)

- System.Windows.Extensions - 5.0.0-alpha.1.19525.3
- System.CodeDom - 5.0.0-alpha.1.19525.3
- System.Configuration.ConfigurationManager - 5.0.0-alpha.1.19525.3
- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.3
- Microsoft.NETCore.Targets - 5.0.0-alpha.1.19525.3
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.3
- Microsoft.Win32.Registry - 5.0.0-alpha.1.19525.3
- Microsoft.Win32.SystemEvents - 5.0.0-alpha.1.19525.3
- Microsoft.Windows.Compatibility - 5.0.0-alpha.1.19525.3
- System.Diagnostics.EventLog - 5.0.0-alpha.1.19525.3
- System.Security.AccessControl - 5.0.0-alpha.1.19525.3
- System.Security.Cryptography.Cng - 5.0.0-alpha.1.19525.3
- System.Security.Cryptography.Pkcs - 5.0.0-alpha.1.19525.3
- System.Security.Cryptography.ProtectedData - 5.0.0-alpha.1.19525.3
- System.Security.Cryptography.Xml - 5.0.0-alpha.1.19525.3
- System.Security.Permissions - 5.0.0-alpha.1.19525.3
- System.Security.Principal.Windows - 5.0.0-alpha.1.19525.3
- System.Text.Encodings.Web - 5.0.0-alpha.1.19525.3
- System.Text.Json - 5.0.0-alpha.1.19525.3
- System.Threading.AccessControl - 5.0.0-alpha.1.19525.3
- System.Resources.Extensions - 5.0.0-alpha.1.19525.3
- System.DirectoryServices - 5.0.0-alpha.1.19525.3
- System.Drawing.Common - 5.0.0-alpha.1.19525.3
- System.IO.FileSystem.AccessControl - 5.0.0-alpha.1.19525.3
- System.IO.Packaging - 5.0.0-alpha.1.19525.3

This change modifies R2RDump to use the new
System.CommandLine.Experimental module instead of the obsoleted
System.CommandLine parser we were using before. Apart from general
hygiene w.r.t. using up-to-date components one practical reason
for this switch-over is that the old parser is only available on
the unreliable myget.org nuget feed we plan to drop as part of
our planned repo consolidation.

During debugging of the change I noticed a bug in the implementation
of the "--verbose" option - it shouldn't be setting EntryPoints,
otherwise we actually end up with a super-terse output including
just the entry points. I have anecdotally verified that, after fixing
this in both the "new" and "old" R2RDump both produce identical output.

Thanks

Tomas

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Improved performance of complex casts by caching results of cast analysis.

* Easy out for same types.
* Introduce cast cache
* Use managed heap for the cache
* Fixes. Get rid of a fake array typedesc.
* TypeDesc conversions caching
* Removed NoGC helpers
* Cache typedesc conversions
* Renamed remaining trivial NoGC casting helpers
* Some cleanups. Comments, redundant code.
* PR feedback.

* Update dependencies from https://github.com/dotnet/coreclr build 20191025.1

- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19525.1
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19525.1
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19525.1

* remove Stopwatch.*.cs from System.Runtime.Extensions build

* Disable tests against CoreCLR bug

…aces

…aces

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

…025.2 (#8673)

- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19525.2
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.19525.2
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19525.2
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.19525.2
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.19525.2
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.19525.2

…025.2 (#42137)

- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19525.2
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19525.2
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.19525.2
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.19525.2
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19525.2
- Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.19525.2
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.19525.2
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.19525.2
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.19525.2
- Microsoft.DotNet.CoreFxTesting - 5.0.0-beta.19525.2
- Microsoft.DotNet.GenAPI - 5.0.0-beta.19525.2
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19525.2
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.19525.2
- Microsoft.DotNet.GenFacades - 5.0.0-beta.19525.2

…91026.1 (#8674)

- NETStandard.Library - 2.2.0-prerelease.19526.1

* Enable building with clang 9

Update the docker images that we use for building.

* Add missing clang9 option to build.sh / build-test.sh

* Fix clang version matching and MUSL build

* Prevent Clang 9 from optimizing out s_gsCookie write

* Can't declare variable and also have extern c

* Remove extern c from variable declartion

)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

The file was there to keep anonymous types used by DiagnosticsHandler from having their getters removed.  But a) it was relying on the implementation detail name generated by Roslyn, and b) it was keeping alive other state from other anonymous types in the assembly.  I changed it to use concrete types instead.  This also happens to result in less code, because we don't need the generated Equals/GetHashCode methods generated for anonymous types.

It's not necessary to specify the assembly name when the consumer is in the same assembly.

* Update dependencies from https://github.com/dotnet/corefx build 20191024.13

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.13
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.13

* Update dependencies from https://github.com/dotnet/corefx build 20191024.14

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.14
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.14

* Update dependencies from https://github.com/dotnet/corefx build 20191025.6

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.6
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.6

* Workaround https://github.com/dotnet/coreclr/issues/27465

- Use PreserveDependencyAttribute for ctors used via reflection by FetcherForProperty
- Remove reflection use entirely when looking up Activity events

* Update dependencies from https://github.com/dotnet/corefx build 20191024.13

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.13
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.13

* Update dependencies from https://github.com/dotnet/corefx build 20191024.14

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.14
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.14

* Update dependencies from https://github.com/dotnet/corefx build 20191025.6

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.6
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.6

* Workaround https://github.com/dotnet/coreclr/issues/27465

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

@jaredpar Updated this doc based on comments on Twitter discussion with you and @dsplaisted

* Revert "Fix the problem with the VS2019 fix on x86 (#26957)"

This reverts commit 4081d86.

* Revert "Fix issue with locals overlapping out of scope GCFrame (#26763)"

This reverts commit 6059e75.

* Fix VS2019 optimization issue take 2

* Stop using FrameWithCookie for GCFrame
* Removed call to SetHasPromotedBytes, the function, the field on
thread and its getter / setter as it is not used for anything.
* Updated ifdefs on GetGCFrame and GetFrame

* Binder utils cleanup

* Binder startup cleanup

* Removing IsSIMDVectorAssembly from the VM layer

* Removing SimdHelper from crossgen2

* Obsoleting isInSIMDModule in the VM layer

* Renaming isInSIMDModule to isIntrinsicType

* Implementing isIntrinsicType for the JIT/EE interface

* Update JITEEVersionIdentifier

* Update crossgen2 JITEEVersionIdentifier

Removed flags:
* Dynamic bind flags were only used for one assert - which is obviously always true (otherwise it would fail)
* Ignore dynamic bind flag was never used.
* Bind cache failures flags was on the other hand always used - so hardcode it directly
* Change the other flags to simple booleans as it makes the code easier to read (and there are now only 2 such flags). Also renamed:
  * cache rerun -> skip failure caching
  * ignore ref/def match -> skip version compatibility check

Minor additional cleanup

Regenerated prebuilt *.idl/*_i.cpp

The stubbed out SecurityElement implementation does not support extensibility that ISecurityElementFactory was designed for.

…026.1 (#8676)

- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19526.1
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.19526.1
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19526.1
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.19526.1
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.19526.1
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.19526.1

…91027.1 (#8677)

- NETStandard.Library - 2.2.0-prerelease.19527.1

* Remove empty lines caused by empty fusion log string

* Remove fusion log more

* Fix NetEventSource in System.Net.Security to properly delegate to events

Two events were set up in correctly, resulting in them getting trimmed away.  The ILLinkTrim.xml was then putting a bandaid on the problem.

* Fix System.Net.Mail.Unit.Tests to not use System.Net.Security internals

The unit tests are currently set up to test internals, and to do so by compiling in the product source.  My thoughts on this aside, it's currently incomplete as it's compiling in some code but then depending on other code via reflection to a completely different assembly.  We shouldn't be combining such approaches.  Delete the reflection code from the unit tests, and update the tests .csproj to include the additional files necessary (we should later revisit this whole scheme).

That lets us delete the ILLinkTrim.xml for the production System.Net.Security assembly.

* Update illink.targets to keep PreserveDependencyAttribute

* Update illink.targets

…2159)

* merge

* CR

* typo

* msbuild /t:GenerateReferenceSource

)

ReadAsyncInternal is correctly passing its token into the two call sites where it delegates directly to the underlying stream, but in one place it calls through ReadBufferAsync, which is currently not defined to take a token.  Fix that, and pass the token through.

There was a bug in the index table - it was pointing to the last
GCRefMap in the previous stride instead of the first one in the new
stride.

I've modified R2RDump too to use the index table when loading GCRefMaps.
While it was not incorrect, the fact that it was not using the index
table has hidden this issue. Now it uses the same algorithm as the
runtime.

* Consolidate .netcoreapp.cs files because System.Runtime project is no longer cross-compiled

Invert the dependency between Compile() and Compile(bool) to avoid rooting the LightCompiler if only Compile() is used.

…odings.Web (#42166)

This is all stale/dead code from before the relevant functionality was made public.

* GcSimulator pipeline and tests

* Disable GC-sim tests on Linux x64 for now until OOMs are resolved.

Saves some allocations and removes a few FCalls/QCalls

…027.3 (#8679)

- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19527.3
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.19527.3
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19527.3
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.19527.3
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.19527.3
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.19527.3

* Remove ILLinkTrim.xml from System.Linq.Expressions

* Address PR feedback

…91028.1 (#8680)

- NETStandard.Library - 2.2.0-prerelease.19528.1

* Update dependencies from https://github.com/dotnet/core-setup build 20191011.7

- Microsoft.NETCore.App - 5.0.0-alpha1.19511.7

* Update dependencies from https://github.com/dotnet/core-setup build 20191013.1

- Microsoft.NETCore.App - 5.0.0-alpha1.19513.1

* Update dependencies from https://github.com/dotnet/core-setup build 20191014.1

- Microsoft.NETCore.App - 5.0.0-alpha1.19514.1

* Update dependencies from https://github.com/dotnet/core-setup build 20191015.17

- Microsoft.NETCore.App - 5.0.0-alpha1.19515.17

* Update dependencies from https://github.com/dotnet/core-setup build 20191016.19

- Microsoft.NETCore.App - 5.0.0-alpha1.19516.19

* Update dependencies from https://github.com/dotnet/core-setup build 20191018.1

- Microsoft.NETCore.App - 5.0.0-alpha1.19518.1

* Update dependencies from https://github.com/dotnet/core-setup build 20191018.11

- Microsoft.NETCore.App - 5.0.0-alpha1.19518.11

* Update dependencies from https://github.com/dotnet/core-setup build 20191019.8

- Microsoft.NETCore.App - 5.0.0-alpha1.19519.8

* Update dependencies from https://github.com/dotnet/core-setup build 20191021.2

- Microsoft.NETCore.App - 5.0.0-alpha1.19521.2

* Update dependencies from https://github.com/dotnet/core-setup build 20191021.12

- Microsoft.NETCore.App - 5.0.0-alpha1.19521.12

* Update dependencies from https://github.com/dotnet/core-setup build 20191022.10

- Microsoft.NETCore.App - 5.0.0-alpha1.19522.10

* Update dependencies from https://github.com/dotnet/core-setup build 20191023.10

- Microsoft.NETCore.App - 5.0.0-alpha1.19523.10

* Update dependencies from https://github.com/dotnet/core-setup build 20191024.4

- Microsoft.NETCore.App - 5.0.0-alpha1.19524.4

* Update dependencies from https://github.com/dotnet/core-setup build 20191025.8

- Microsoft.NETCore.App - 5.0.0-alpha1.19525.8

* Update dependencies from https://github.com/dotnet/core-setup build 20191026.2

- Microsoft.NETCore.App - 5.0.0-alpha1.19526.2

* Update dependencies from https://github.com/dotnet/core-setup build 20191027.2

- Microsoft.NETCore.App - 5.0.0-alpha1.19527.2

* Update dependencies from https://github.com/dotnet/corefx build 20191026.6

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19526.6
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19526.6

* Update dependencies from https://github.com/dotnet/corefx build 20191027.5

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19527.5
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19527.5

With this change, Crossgen2 passes basic validation. If possible,
I would love to be able to merge this in ASAP as it's of paramount
importance for our repo consolidation efforts. I'll be happy to
follow up cleaning this change as necessary.

1) Update to a newer version of the System.CommandLine.Experimental
package enabling more general binding syntax needed for unambiguous
binding of multi-value arguments vs. options.

2) Explicitly specify arity for multi-value options as for whatever
reason the default maximum is 255 (lower than the number of reference
assemblies in Core_Root, for instance).

3) Reference paths cannot be bound to FileInfo[] as their syntax
supports wildcards.

Thanks

Tomas

* Preparatory changes for EH WriteThru

- Add a method on BasicBlock to determine EH flow in or out

* Switch to label.N form for pre-release label
In order to facilitate better preview sorting, switch to label.N form for the pre-release label.

We need to use it in corelib, too.

* Delete empty FireCustomerDebugProbe FCall

* Delete duplicate C++ compiler command line options

* Add support to produce WebAssembly runtime assets

* Add support to build in OSX and address PR feedback

* Change AND -> and in Directory.Build.props change region

* PR Feedback: run build in rolling CI builds as well

* Add TODO comment for WebAssembly OSGroup

* Fix indentation.

* Fix wrong #include as apis defined in that include are used outside of ETHTOOL_H #if-def

…ypeConverter (#42182)

Today, R2R compilation of test MSIL using Crossgen happens during
test execution in Helix. This means that the managed artifacts for a
given OS / architecture / config combo are identical for a R2R /
non-R2R job. Additionally, we need very few artifacts for running
the CoreFX tests. In practice it turns out we only need to build the
test host. We can exploit these facts to further reduce the number
of test build jobs in CoreCLR pipelines.

Thanks

Tomas

* Fix GCStress C issue with the fix to VS2019 optimization

There is a place in the runtime that we hit during GCStress C and that
was creating uninitialized GCFrame and initializing it only
conditionally. In the GCFrame destructor, we always try to pop the
GCFrame out of the per-thread linked list and this was breaking it.

The fix is to always initialize the GCFrame. In the problematic place,
it was not being initialized / pushed on the linked list when number of
GC slots it was to protect was 0. But the logic in GCFrame works just
fine even in that case, so I've made the initialization over there
unconditional.

I've also made a couple of methods in the GCFrame private as they are
never supposed to be called from the outside, removed the default
GCFrame constructor so that noone can create uninitialized GCFrame
anymore and also removed placement new from GCFrame that doesn't seem to
have any purpose.

* Reflect more feedback

* Folded the Pop and Push functions into their callers
* Folded the Initialize to the constructor

…Remove src/pal/inc/pal_unwind.h (#27509)

Fixes #27503

The destructor cleans up resources allocated by MethodCallSummarizer
during its normal lifetime.

…42184)

* Consolidate .netcoreapp.cs files because System.Runtime.Extensions project is no longer cross-compiled

* Fix AppDomainTests