-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update System.Speech to also recognize Speech_OneCore #110123
base: main
Are you sure you want to change the base?
Conversation
@@ -21,7 +21,12 @@ protected ObjectTokenCategory(string keyId, RegistryDataKey key) | |||
internal static ObjectTokenCategory Create(string sCategoryId) | |||
{ | |||
RegistryDataKey key = RegistryDataKey.Open(sCategoryId, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this doesn't throw if the key isn't there -- it ends up calling into the COM interface so I guess that's the case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't discussed - I haven't heard of this. See no problem with it, but wouldn't this apply to .NET Framework as well? (Perhaps a similar change was already made there by someone?)
If we were still adding features there, sure. |
Without context, I don't know whether it's adding features, or simply ensuring the scenario continues to work fully. Anyway, separate to this. |
does this fix #108991 |
Possibly. It depends which voices they mean. This won't help with the "natural voices". |
Closes #110120
@danmoseley, I believe you ported System.Speech over to core. Are you aware of reasons to not do this? Is there someone we should ask?