Enable more ILLink test cases with native AOT #110166
Conversation
When I was working on the `DAMT.All*`, I noticed we don't run many Reflection tests, this is progress towards that. Also fixes rare `CreateInstance` overloads - these were never worth the effort to implement honestly, but more code sharing made implementing them a breeze. Contributes to dotnet#82447.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
|
@sbomer could you have a look please? |
| { | ||
| // It's not wrong to have a reference to non-existing type - the code may well expect to get an exception in this case | ||
| // Note that we did find the assembly, so it's not a ILLink config problem, it's either intentional, or wrong versions of assemblies | ||
| // but ILLink can't know that. In case a user tries to create an array using System.Activator we should simply ignore it, the user |
There was a problem hiding this comment.
For ILLink this logic has a check for array types - why do we check that for ILLink but not ILC?
There was a problem hiding this comment.
That part traces back to dotnet/linker#1566.
The original logic was actually:
var typeRef = _context.TypeNameResolver.ResolveTypeName (resolvedAssembly, typeNameStringValue.Contents);
var resolvedType = typeRef?.Resolve ();
if (resolvedType == null || typeRef is ArrayType) {So this compensates for the Cecil quirk where a TypeReference for an array type will "resolve" into System.Array for reasons that I never understood.
What is there today is semantically different, it was lost in some of the refactors:
if (!_reflectionMarker.TryResolveTypeNameAndMark (resolvedAssembly, typeName, _diagnosticContext, out TypeReference? foundType)
|| foundType.IsTypeOf (WellKnownType.System_Array)) {This will let arrays through and instead treats System.Array as nothing.
In the end, I don't think this matters. If we were to delete the array special handling, I don't think it would have any observable effect.
src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCases/TestSuites.cs
Outdated
Show resolved
Hide resolved
…Suites.cs Co-authored-by: kasperk81 <83082615+kasperk81@users.noreply.github.com>
|
/ba-g timeouts in legs that don't exercise these code paths |
When I was working on the `DAMT.All*`, I noticed we don't run many Reflection tests, this is progress towards that. Also fixes rare `CreateInstance` overloads - these were never worth the effort to implement honestly, but more code sharing made implementing them a breeze. Contributes to dotnet#82447.
When I was working on the `DAMT.All*`, I noticed we don't run many Reflection tests, this is progress towards that. Also fixes rare `CreateInstance` overloads - these were never worth the effort to implement honestly, but more code sharing made implementing them a breeze. Contributes to dotnet#82447.
When I was working on the
DAMT.All*, I noticed we don't run many Reflection tests, this is progress towards that.Also fixes rare
CreateInstanceoverloads - these were never worth the effort to implement honestly, but more code sharing made implementing them a breeze.Contributes to #82447.
Cc @dotnet/ilc-contrib