Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update runtime maintenance-packages dependencies to latest when not in source-build #110172

Closed
wants to merge 1 commit into from

Conversation

carlossanlop
Copy link
Member

Workaround to unblock the runtime->sdk deps flow. I already applied it as patch to that PR: https://github.com/dotnet/sdk/pull/45042/files

That runtime->sdk deps flow PR is blocked by roslyn because that repo will downgrade the package version after finding that runtime had the versions updated to a newer version.

Roslyn cannot immediately get these same dependencies updated because msbuild will fail to find them: https://github.com/dotnet/roslyn/pull/76076/files

MSBuild needs to get these package versions updated before all other repos: dotnet/msbuild#11038

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

 latest when not in source-build. Tracking issue:
 dotnet/sdk#45155
@carlossanlop
Copy link
Member Author

Closing. We decided we do not want to condition the runtime dependencies as they're not currently causing issues. The main problem is coming from roslyn.

@carlossanlop carlossanlop deleted the PatchForMPDeps branch November 27, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant