Only update runtime maintenance-packages dependencies to latest when not in source-build #110172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
3 tasks
latest when not in source-build. Tracking issue: dotnet/sdk#45155
carlossanlop
force-pushed
the
PatchForMPDeps
branch
from
ea1c642 to
1c6d00f
Compare
|
Closing. We decided we do not want to condition the runtime dependencies as they're not currently causing issues. The main problem is coming from roslyn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround to unblock the runtime->sdk deps flow. I already applied it as patch to that PR: https://github.com/dotnet/sdk/pull/45042/files
That runtime->sdk deps flow PR is blocked by roslyn because that repo will downgrade the package version after finding that runtime had the versions updated to a newer version.
Roslyn cannot immediately get these same dependencies updated because msbuild will fail to find them: https://github.com/dotnet/roslyn/pull/76076/files
MSBuild needs to get these package versions updated before all other repos: dotnet/msbuild#11038