NamedPipeClientStream Connect with SafePipeHandle #110175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check that isConnected in the NamedPipeClientStream constructor is always true. * Added an argument test. Fixes dotnet#32760
dotnet-policy-service
bot
added
the
community-contribution
huoyaoyuan
reviewed
Nov 26, 2024
| @@ -110,7 +110,7 @@ private bool TryConnect(int timeout) | |||
| _pipeFlags |= (((int)_impersonationLevel - 1) << 16); | |||
| } | |||
|
|
|||
| SafePipeHandle handle = CreateNamedPipeClient(_normalizedPipePath, ref secAttrs, _pipeFlags, _accessRights); | |||
There was a problem hiding this comment.
When the logic is not around, it's better using assert instead of the suppression operator. One assert can cover all subsequent usages.
3 tasks
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of #110075 without the change to the public API.
Fixes #32760