Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Update .NET 8 build images to use Azure Linux #110199

Open
wants to merge 1 commit into
base: release/8.0-staging
Choose a base branch
from

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Nov 26, 2024

Replaces the build images for which we have equivalent Azure Linux images (see dotnet/dotnet-buildtools-prereqs-docker#1173).

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 26, 2024
env:
ROOTFS_DIR: /crossrootfs/x64

wasi_wasm:
image: mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-webassembly-20230913040940-1edc1c6
image: mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-net8.0-webassembly-amd64
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reintroduces floating tags which were removed in #92232. I don't have context on what that fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked at that change. Do we have a policy on that? I don't see a tracking issue to un-fix the reference. We should never accept such a change w/o a tracking issue to remediate the fixed image reference. I assume you agree.

@carlossanlop

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I think we want to use floating tags, and only pin them temporarily if needed to unblock builds.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start writing guidance on how to manage all of this?

@sbomer sbomer requested review from a team and richlander November 26, 2024 18:49
@teo-tsirpanis teo-tsirpanis added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 28, 2024
@teo-tsirpanis teo-tsirpanis added this to the 8.0.x milestone Nov 28, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants