-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Update .NET 8 build images to use Azure Linux #110199
base: release/8.0-staging
Are you sure you want to change the base?
Conversation
env: | ||
ROOTFS_DIR: /crossrootfs/x64 | ||
|
||
wasi_wasm: | ||
image: mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-webassembly-20230913040940-1edc1c6 | ||
image: mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-net8.0-webassembly-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reintroduces floating tags which were removed in #92232. I don't have context on what that fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just looked at that change. Do we have a policy on that? I don't see a tracking issue to un-fix the reference. We should never accept such a change w/o a tracking issue to remediate the fixed image reference. I assume you agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I think we want to use floating tags, and only pin them temporarily if needed to unblock builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we start writing guidance on how to manage all of this?
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Replaces the build images for which we have equivalent Azure Linux images (see dotnet/dotnet-buildtools-prereqs-docker#1173).