Fix Configuration to throw with ErrorOnUnknownConfiguration option #110209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ericstj
reviewed
Dec 3, 2024
src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
Outdated
Show resolved
Hide resolved
This was referenced Dec 3, 2024
Open
eduardo-vp
pushed a commit
to eduardo-vp/runtime
that referenced
this pull request
Dec 5, 2024
…otnet#110209) * Fix Configuration to throw with ErrorOnUnknownConfiguration option * Fix the fired Debug.Assert * address the feedback
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
…otnet#110209) * Fix Configuration to throw with ErrorOnUnknownConfiguration option * Fix the fired Debug.Assert * address the feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110147
This change addresses a regression introduced in
Microsoft.Extensions.Configuration.Binderversion 9.0.0. The issue occurs when binding a configuration withErrorOnUnknownConfigurationset totrue, where anInvalidOperationExceptionshould be thrown. The regression specifically affects scenarios involving collections, where binding collection values to invalid configuration values does not behave as expected.The original change caused the regression is #97777
The change is ensuring back to the .NET 8.0 behavior, but we should look at fixing the source generator in general with
ErrorOnUnknownConfiguration.