JIT: Remove references to "CSE candidate" in morph #110218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSE no longer reinvokes morph, and the checks for CSE were removed in 07f15ef. However, a few comments were left over, so clean those up.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
cc @dotnet/jit-contrib PTAL @EgorBo |
jakobbotsch
changed the title
EgorBo
approved these changes
Nov 27, 2024
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
CSE no longer reinvokes morph, and the checks for CSE were removed in 07f15ef. However, a few comments were left over, so clean those up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSE no longer reinvokes morph, and the checks for CSE were removed in 07f15ef. However, a few comments were left over, so clean those up.
I audited the
fgGlobalMorphuses as well but most of these are guarding against transformations messing up VNs, so it looks like they cannot be removed (yet).Fix #108875