Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix increment in decreasing loop in non-shipping code #110219

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix increment in decreasing loop in non-shipping code #110219

merged 1 commit into from
Dec 3, 2024

Conversation

jakobbotsch
Copy link
Member

Fix #100825

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 27, 2024
EgorBo
EgorBo approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious - does roslyn produce a warning here?

@build-analysis build-analysis bot mentioned this pull request Nov 27, 2024
Open
@jakobbotsch
Copy link
Member Author

just curious - does roslyn produce a warning here?

It does not.

@build-analysis build-analysis bot mentioned this pull request Dec 3, 2024
Open
@jakobbotsch jakobbotsch merged commit efd5a63 into dotnet:main Dec 3, 2024
86 of 88 checks passed
@jakobbotsch jakobbotsch deleted the fix-100825 branch December 3, 2024 15:54
eduardo-vp pushed a commit to eduardo-vp/runtime that referenced this pull request Dec 5, 2024
@jakobbotsch @eduardo-vp
Fix increment in decreasing loop in non-shipping code (dotnet#110219)
23811b3 
Fix dotnet#100825
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@jakobbotsch @mikelle-rogers
Fix increment in decreasing loop in non-shipping code (dotnet#110219)
4ffc948 
Fix dotnet#100825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loop goes in wrong direction
2 participants
@jakobbotsch @EgorBo