Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-staging] Avoid exception when parsing AD path for port number #110224

Open
wants to merge 1 commit into
base: release/9.0-staging
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 27, 2024

Backport of #109977 to release/9.0-staging

Fixes #109858

Customer Impact

  • Customer reported

This is breaking existing users of Active Directory through System.DirectoryServices.AccountManagement although there appears to be a workaround.

Regression

  • Yes
  • No

Regression in v9 from #89787.

Testing

There is pending community testing.

This is an ActiveDirectory issue which is hard to test since it requires either local usage of AD or a setup of virtual machine(s) to test. There are no automated tests.

Risk

Low; even though the test has not yet been verified the change is to simply change from calling the constructor of the System.Uri class to using System.Uri.TryCreate().

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014
See info in area-owners.md if you want to be subscribed.

@steveharter steveharter added this to the 9.0.x milestone Nov 27, 2024
@steveharter steveharter added the Servicing-consider Issue for next servicing release review label Nov 27, 2024
@steveharter steveharter self-assigned this Nov 27, 2024
@steveharter steveharter requested a review from ericstj November 27, 2024 16:19
@rbhanda rbhanda modified the milestones: 9.0.x, 9.0.2 Dec 10, 2024
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants