JIT: Remove fgRenumberBlocks calls in loop opt phases
#110227
Merged
+7
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
reviewed
Nov 27, 2024
| @@ -5145,37 +5145,18 @@ BasicBlockVisit FlowGraphNaturalLoop::VisitLoopBlocks(TFunc func) | |||
| template <typename TFunc> | |||
| BasicBlockVisit FlowGraphNaturalLoop::VisitLoopBlocksLexical(TFunc func) | |||
There was a problem hiding this comment.
We should likely just remove it. The usages are just for duplicating loop blocks, and those probably don't need to be duplicated lexically anymore.
No need to make the change here if you don't want to, I can do it separately.
There was a problem hiding this comment.
Got it, I saw #110020 is introducing new call sites for it, so I decided to keep it around to avoid conflicts with that PR. I can remove it in one go once that PR is in.
3 tasks
jakobbotsch
approved these changes
Nov 28, 2024
|
Small diffs from the |
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
Follow-up to dotnet#110026. This required a small refactor of FlowGraphNaturalLoop::VisitLoopBlocksLexical to remove its bbNum checks.
amanasifkhalid
added a commit
that referenced
this pull request
Dec 12, 2024
Follow-up to #110227. In the few places where we still visit loop blocks in lexical order, just visit them in RPO instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #110026. This required a small refactor of
FlowGraphNaturalLoop::VisitLoopBlocksLexicalto remove itsbbNumchecks.