Disable GFNI tests for NAOT

[saucecontrol]

Fixes #110240

GFNI is enabled opportunistically, and the HWIntrinsics tests check that the methods throw PNSE when not supported. On NAOT, instead of throwing, the instructions are emitted, so they result in illegal instruction instead.

[saucecontrol]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Commenter does not have sufficient privileges for PR 110250 in repo dotnet/runtime

[saucecontrol]

CC @MichalStrehovsky @tannergooding @jkotas

[MichalStrehovsky]

/azp run runtime-nativeaot-outerloop

[saucecontrol]

For reference, the test that was failing:

runtime/src/tests/JIT/HardwareIntrinsics/X86/Shared/GfniAffineTest.template

Lines 229 to 248 in d6eb354

	public void RunUnsupportedScenario()
	{
	TestLibrary.TestFramework.BeginScenario(nameof(RunUnsupportedScenario));
	bool succeeded = false;
	try
	{
	RunBasicScenario_UnsafeRead();
	}
	catch (PlatformNotSupportedException)
	{
	succeeded = true;
	}
	if (!succeeded)
	{
	Succeeded = false;
	}
	}

This template is common across HWIntrinsics tests, and any of these will fail when an unsupported instruction set is allowed in NAOT.

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jkotas]

This template is common across HWIntrinsics tests, and any of these will fail when an unsupported instruction set is allowed in NAOT.

The other tests dealt with the problem by getting disabled: https://github.com/dotnet/runtime/blob/main/src/tests/JIT/HardwareIntrinsics/X86/X86Serialize/Serialize_r.csproj#L6-L7 . Should we do the same here?

Ideally, the opportunistic set would contain all instructions by default. The only reason why it is not the case are JIT instruction encoding limitations.

[saucecontrol]

Got it, thanks. I've only added the property for the base Gfni tests for now. If the outerloop tests are run with --instruction-set=avx or higher, more things can fail. Should we disable NAOT tests for anything that isn't expected to be supported in CI?

[MichalStrehovsky]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[MichalStrehovsky]

Got it, thanks. I've only added the property for the base Gfni tests for now. If the outerloop tests are run with --instruction-set=avx or higher, more things can fail. Should we disable NAOT tests for anything that isn't expected to be supported in CI?

We don't really test with --instruction-set, except for a couple native AOT smoke tests. We'd need to do more work if we want to support this as a documented switch and that includes running more tests with these switches set (the switch is currently undocumented on learn.microsoft.com and we treat it as soft-documented).

[jkotas]

This template is common across HWIntrinsics tests, and any of these will fail when an unsupported instruction set is allowed in NAOT.

It would be nice to fix this template to be compatible with native AOT: #110293

[MichalStrehovsky]

Thank you!