Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unhandled exception handler API to match approved shape. #110254

Merged
merged 6 commits into from
Nov 30, 2024
Merged

Update unhandled exception handler API to match approved shape. #110254

merged 6 commits into from
Nov 30, 2024

Conversation

teo-tsirpanis
Copy link
Contributor

@dotnet-issue-labeler dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Nov 28, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 28, 2024
@teo-tsirpanis teo-tsirpanis mentioned this pull request Nov 28, 2024
Merged
@teo-tsirpanis teo-tsirpanis added area-ExceptionHandling-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 28, 2024
@jkotas jkotas requested a review from VSadov November 28, 2024 23:37
jkotas
jkotas approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@build-analysis build-analysis bot mentioned this pull request Nov 29, 2024
Open
3 tasks
jkotas
jkotas requested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs more changes to fix build breaks.

@VSadov
Copy link
Member

VSadov commented Nov 29, 2024

Test.CoreLib is a limited runtime and does not have Func delegates declared as they were not needed so far.

This change needs that at least Func`2 is declared in the test lib.

This was referenced Nov 29, 2024
Open
Open
jkotas
jkotas approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas merged commit 1db85e8 into dotnet:main Nov 30, 2024
139 checks passed
@teo-tsirpanis teo-tsirpanis deleted the ueh-fix branch November 30, 2024 17:11
eduardo-vp pushed a commit to eduardo-vp/runtime that referenced this pull request Dec 5, 2024
@teo-tsirpanis @VSadov
@jkotas @eduardo-vp
Update unhandled exception handler API to match approved shape. (dotn…
73e6b6b 
…et#110254)

* Update unhandled exception handler API to match approved shape.

* Update the correct API in the reference assembly.

* IsHandledByGlobalHandler  helper

---------

Co-authored-by: vsadov <8218165+VSadov@users.noreply.github.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@teo-tsirpanis @VSadov
@jkotas @mikelle-rogers
Update unhandled exception handler API to match approved shape. (dotn…
0956c7c 
…et#110254)

* Update unhandled exception handler API to match approved shape.

* Update the correct API in the reference assembly.

* IsHandledByGlobalHandler  helper

---------

Co-authored-by: vsadov <8218165+VSadov@users.noreply.github.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

@VSadov VSadov Awaiting requested review from VSadov

Assignees
No one assigned
Labels
area-ExceptionHandling-coreclr community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teo-tsirpanis @VSadov @jkotas