-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unhandled exception handler API to match approved shape. #110254
Conversation
Note regarding the
|
1 similar comment
Note regarding the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs more changes to fix build breaks.
Test.CoreLib is a limited runtime and does not have Func delegates declared as they were not needed so far. This change needs that at least Func`2 is declared in the test lib. |
This reverts commit 72f772e.
src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/__Finalizer.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…et#110254) * Update unhandled exception handler API to match approved shape. * Update the correct API in the reference assembly. * IsHandledByGlobalHandler helper --------- Co-authored-by: vsadov <8218165+VSadov@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>
…et#110254) * Update unhandled exception handler API to match approved shape. * Update the correct API in the reference assembly. * IsHandledByGlobalHandler helper --------- Co-authored-by: vsadov <8218165+VSadov@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>
See #109806 (comment)