Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-staging] [mono][aot] Fix compilation crashes when type load exception is generated in code #110271

Open
wants to merge 2 commits into
base: release/9.0-staging
Choose a base branch
from

Conversation

BrzVlad
Copy link
Member

@BrzVlad BrzVlad commented Nov 29, 2024

Backport of #110078 to release/9.0-staging

Customer Impact

AOT of some assemblies can lead to compilation crashes, on iOS for example. This would force users to use interpreter instead.

Regression

Yes.

Testing

Tested with sample application provided by customer.

Risk

Low. In rare cases, when typeload exception was detected during compile time, we were emitting code to throw this exception at runtime (this was behavior introduced in net9). This functionality had bugs leading to crashes instead during compilation. This PR has impact only on those scenarios that were already crashing.

Method compilation was continuing and we ended up failing with invalid IL.
…ption throw

In the final stages of method compilation, when trying to compute clause ranges, we were asserting because the clause bblocks haven't been reached for compilation.
Copy link
Contributor

Tagging subscribers to this area: @steveisok, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Codegen-JIT-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant