-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Helper Method Frames (HMF) from Reflection #110377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and RuntimeMethodHandle.GetLoaderAllocator().
Tagging subscribers to this area: @mangod9 |
This was referenced Dec 4, 2024
Open
@EgorBot -windows_intel using System;
using System.Runtime.InteropServices;
using BenchmarkDotNet.Attributes;
public class Bench
{
[Benchmark]
public bool IsEquivalentTo() => typeof(A.IFoo).IsEquivalentTo(typeof(B.IFoo));
}
namespace A
{
[TypeIdentifier]
[ComImport]
[Guid("8eabdc2b-1689-459d-9726-8b2454aadef5")]
public interface IFoo
{
}
}
namespace B
{
[TypeIdentifier]
[ComImport]
[Guid("8eabdc2b-1689-459d-9726-8b2454aadef5")]
public interface IFoo
{
}
} |
@EgorBot -windows_intel using System;
using System.Runtime.InteropServices;
using BenchmarkDotNet.Attributes;
public class Bench
{
[Benchmark]
public bool IsEquivalentTo() => typeof(A.IFoo).IsEquivalentTo(typeof(B.IFoo));
}
namespace A
{
[TypeIdentifier]
[ComImport]
[Guid("8eabdc2b-1689-459d-9726-8b2454aadef5")]
public interface IFoo
{
}
}
namespace B
{
[TypeIdentifier]
[ComImport]
[Guid("8eabdc2b-1689-459d-9726-8b2454aadef5")]
public interface IFoo
{
}
} |
jkotas
reviewed
Dec 5, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove HMF from
RuntimeFieldHandle.GetLoaderAllocator()
andRuntimeMethodHandle.GetLoaderAllocator()
.Convert
RuntimeTypeHandle.IsEquivalentTo()
to QCall.Convert
RuntimeTypeHandle.GetMethodAt()
to QCall.Remove HMF from
Signature.GetParameterOffset()
.Clean up TypeEquivalence feature defines.
Convert
RuntimeTypeHandle.GetArgumentTypesFromFunctionPointer()
to QCall.