Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] [debugger] Support step into a tail call #110440

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 5, 2024

Backport of #110334 to release/8.0-staging

/cc @thaystg

Customer Impact

  • Customer reported
  • Found internally

#110441
A customer ships a compiler that uses tail calls and when their customers are debugging the app generated by this compiler and try to step into a tail call it behaves like a resume.

Regression

  • Yes
  • No

It works before .NET 6.

Testing

We manually tested using this internal test https://github.com/dotnet/runtime/blob/e99557baffbe864d624cc1c95c9cbf2eefae684f/src/tests/JIT/Regression/JitBlue/Runtime_39581/Runtime_39581.il and trying to step into the Callee.

Risk

Low risk, this will only affect the scenarios where we emit a tail call using the StoreTailCallArgs, which is not used a lot. As far as I understood it's impossible to generate it from a C# code, only F# and IL.

Addressing Tom's and Mikelle's comments

Removing unrelated change and adding enum

Changing the comment.
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@teo-tsirpanis teo-tsirpanis added this to the 8.0.x milestone Dec 5, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we will take for consideration in 8.0.x

@thaystg
Copy link
Member

thaystg commented Dec 9, 2024

Approved by email.

@thaystg thaystg added the Servicing-approved Approved for servicing release label Dec 9, 2024
@thaystg thaystg merged commit eda4c70 into release/8.0-staging Dec 10, 2024
107 of 118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants