[cdac] Handle no method def token when trying to get the IL version state #110449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinor-fung
requested review from
davidwrighton,
AaronRobinsonMSFT and
max-charlamb
dotnet-issue-labeler
bot
added
the
needs-area-label
elinor-fung
added
area-Diagnostics-coreclr
and removed
needs-area-label
11 tasks
max-charlamb
reviewed
Dec 5, 2024
...ed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/CodeVersions_1.cs
Outdated
Show resolved
Hide resolved
...acreader/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated
Show resolved
Hide resolved
This was referenced Dec 5, 2024
AaronRobinsonMSFT
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some methods have a nil token - for example, special runtime methods like array functions. When we tried to look up their IL version state, we were throwing an exception. Methods like this will have no versioning state, so check for a nil token and skip the lookup.
Found this while trying to finish out
RuntimeTypeSystem_1.GetMethodClassificationDataTypefor #109426 when doing a!dumpmdfor an array function. I also uncovered another issue where we aren't getting the native code slot correctly for some methods, but haven't fixed that yet - will be a separate change.Contributes to #99302, #109426