[clr-interp] Setup fully interpreted functional test on iOS simulator #118889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AaronRobinsonMSFT
added
area-CodeGen-Interpreter-coreclr
and removed
area-Interop-coreclr
labels
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
kg
reviewed
Aug 19, 2025
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml
Outdated
Show resolved
Hide resolved
kg
reviewed
Aug 19, 2025
kg
reviewed
Aug 19, 2025
kg
reviewed
Aug 19, 2025
...ctionalTests/iOS/Simulator/CoreCLR.Interpreter/iOS.Simulator.CoreCLR.Interpreter.Test.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
|
/azp run runtime-iossimulator |
|
No pipelines are associated with this pull request. |
|
/azp run runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-iossimulator |
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike,runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike,runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike,runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kotlarmilos
requested review from
BrzVlad,
AaronRobinsonMSFT,
tannergooding and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR enables fully interpreted execution for CoreCLR on iOS simulator by configuring static linking and implementing required interpreter intrinsics. The changes simplify the functional test configuration and extend interpreter support for Interlocked.Exchange operations.
- Configures CoreCLR for static linking on iOS platforms instead of dynamic linking
- Implements
Interlocked.Exchangeintrinsics in the interpreter for int32 and int64 types - Simplifies the functional test to use direct interpretation mode and removes async components
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| iOS.Simulator.CoreCLR.Interpreter.Test.csproj | Updates environment variables to use simplified interpreter mode configuration |
| Program.cs | Simplifies test program by removing async operations and external dependencies |
| Xcode.cs | Modifies build system to use static libraries (.a files) instead of dynamic libraries (.dylib) for CoreCLR |
| CMakeLists.txt files | Extends static library installation to iOS/tvOS/MacCatalyst platforms |
| AppleBuild.targets | Adds copying of static CoreCLR library for static linking scenarios |
| prestub.cpp | Updates interpreter call stub creation condition to exclude WASM targets |
| interpexec.cpp | Implements execution logic for Exchange intrinsics and adds macro cleanup |
| intrinsics.cpp | Adds recognition of Interlocked.Exchange method intrinsic |
| intops.def | Defines new interpreter opcodes for Exchange operations |
| compiler.cpp | Implements compilation logic for Exchange intrinsics |
| coreclr/CMakeLists.txt | Extends static library linking configuration to iOS platforms |
| clrfeatures.cmake | Updates feature flags to disable JIT and enable static linking for iOS platforms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the functional test to fully interpret the startup path and Main method. It statically links the runtime and interpreter, and implements the
Interlocked.Exchangemust-expand intrinsics.Contributes to #118647