Fix trace state key parsing in W3C propagator to support digits #119778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the W3C propagator trace state key parsing to support digits according to the W3C specification. The implementation was previously only accepting lowercase letters at the start of keys, but the spec allows both lowercase letters and digits.
Key changes:
- Updated trace state key validation to accept digits (0-9) in addition to lowercase letters (a-z)
- Modified both .NET 6+ and legacy implementations to support the expanded character set
- Updated test cases to reflect that keys starting with digits are now valid
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| W3CPropagator.cs | Updated key validation logic to accept digits in trace state keys per W3C spec |
| W3CPropagatorTests.cs | Modified test cases to validate digit support and updated comments |
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/W3CPropagator.cs
Show resolved
Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/W3CPropagator.cs
Show resolved
Hide resolved
tarekgh
added
area-System.Diagnostics.Activity
and removed
needs-area-label
|
CC @MihaZupan |
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity |
noahfalk
approved these changes
Sep 16, 2025
jeffhandley
approved these changes
Sep 16, 2025
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/W3CPropagator.cs
Show resolved
Hide resolved
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17784264902 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The W3C propagator is a new feature in .NET 10. We previously missed supporting digits when parsing trace state keys. According to the specification, digits are valid in keys. This change fixes that by adding support for digits in trace state keys. I am planning to back port this to 10 release.
#119767
#114583
#103174